components/search_provider_logos/logo_tracker.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_provider_logos/logo_tracker.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/search_engines/template_url_fetcher.cc ('k') | components/signin/core/browser/gaia_cookie_manager_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/search_provider_logos/logo_tracker.cc

diff --git a/components/search_provider_logos/logo_tracker.cc b/components/search_provider_logos/logo_tracker.cc

index 855fe1e589b67813cb49e3ef2a4e293611b3c583..6e8ad20f8d476968c84479d2cd4afce382aa703b 100644

--- a/components/search_provider_logos/logo_tracker.cc

+++ b/components/search_provider_logos/logo_tracker.cc

@@ -208,7 +208,7 @@ void LogoTracker::FetchLogo() {

}

url = append_queryparams_func_.Run(logo_url_, fingerprint, wants_cta_);

- fetcher_.reset(net::URLFetcher::Create(url, net::URLFetcher::GET, this));

+ fetcher_ = net::URLFetcher::Create(url, net::URLFetcher::GET, this);

fetcher_->SetRequestContext(request_context_getter_.get());

fetcher_->Start();

}

« no previous file with comments | « components/search_engines/template_url_fetcher.cc ('k') | components/signin/core/browser/gaia_cookie_manager_service.h » ('j') | no next file with comments »