Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/wizard_controller_browsertest.cc
diff --git a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
index 6f7280a1a4e8e86fc744094ff4e20af46813339a..9e9f1a812c6e1b4444dce38d85445223eeca6569 100644
--- a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
+++ b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
@@ -376,28 +376,25 @@ IN_PROC_BROWSER_TEST_F(WizardControllerTest, VolumeIsAdjustedForChromeVox) {
class WizardControllerTestURLFetcherFactory
: public net::TestURLFetcherFactory {
public:
- net::URLFetcher* CreateURLFetcher(int id,
- const GURL& url,
- net::URLFetcher::RequestType request_type,
- net::URLFetcherDelegate* d) override {
+ scoped_ptr<net::URLFetcher> CreateURLFetcher(
+ int id,
+ const GURL& url,
+ net::URLFetcher::RequestType request_type,
+ net::URLFetcherDelegate* d) override {
if (StartsWithASCII(
url.spec(),
SimpleGeolocationProvider::DefaultGeolocationProviderURL().spec(),
true)) {
- return new net::FakeURLFetcher(url,
- d,
- std::string(kGeolocationResponseBody),
- net::HTTP_OK,
- net::URLRequestStatus::SUCCESS);
+ return scoped_ptr<net::URLFetcher>(new net::FakeURLFetcher(
+ url, d, std::string(kGeolocationResponseBody), net::HTTP_OK,
+ net::URLRequestStatus::SUCCESS));
}
if (StartsWithASCII(url.spec(),
chromeos::DefaultTimezoneProviderURL().spec(),
true)) {
- return new net::FakeURLFetcher(url,
- d,
- std::string(kTimezoneResponseBody),
- net::HTTP_OK,
- net::URLRequestStatus::SUCCESS);
+ return scoped_ptr<net::URLFetcher>(new net::FakeURLFetcher(
+ url, d, std::string(kTimezoneResponseBody), net::HTTP_OK,
+ net::URLRequestStatus::SUCCESS));
}
return net::TestURLFetcherFactory::CreateURLFetcher(
id, url, request_type, d);

Powered by Google App Engine
This is Rietveld 408576698