Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Unified Diff: chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unneeded Pass() calls Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
diff --git a/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc b/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
index 24396491e281791d2e0f79aaf6d03c4e39d88020..93d35c785318b0ebd6b23c0796c7f504535cdf52 100644
--- a/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
+++ b/chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc
@@ -70,10 +70,11 @@ class FakeURLFetcherFactory : public net::FakeURLFetcherFactory {
~FakeURLFetcherFactory() override;
// net::FakeURLFetcherFactory:
- net::URLFetcher* CreateURLFetcher(int id,
- const GURL& url,
- net::URLFetcher::RequestType request_type,
- net::URLFetcherDelegate* delegate) override;
+ scoped_ptr<net::URLFetcher> CreateURLFetcher(
+ int id,
+ const GURL& url,
+ net::URLFetcher::RequestType request_type,
+ net::URLFetcherDelegate* delegate) override;
private:
DISALLOW_COPY_AND_ASSIGN(FakeURLFetcherFactory);
@@ -86,15 +87,16 @@ FakeURLFetcherFactory::FakeURLFetcherFactory()
FakeURLFetcherFactory::~FakeURLFetcherFactory() {
}
-net::URLFetcher* FakeURLFetcherFactory::CreateURLFetcher(
+scoped_ptr<net::URLFetcher> FakeURLFetcherFactory::CreateURLFetcher(
int id,
const GURL& url,
net::URLFetcher::RequestType request_type,
net::URLFetcherDelegate* delegate) {
- net::URLFetcher* fetcher = net::FakeURLFetcherFactory::CreateURLFetcher(
- id, url, request_type, delegate);
+ scoped_ptr<net::URLFetcher> fetcher =
+ net::FakeURLFetcherFactory::CreateURLFetcher(id, url, request_type,
+ delegate);
EXPECT_TRUE(fetcher);
- return fetcher;
+ return fetcher.Pass();
}
} // namespace
« no previous file with comments | « chrome/browser/chromeos/login/wizard_controller_browsertest.cc ('k') | chrome/browser/chromeos/policy/upload_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698