components/gcm_driver/gcm_channel_status_request.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_channel_status_request.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/devtools_ui.cc ('K') | « components/feedback/feedback_uploader_chrome.cc ('k') | components/google/core/browser/google_url_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/gcm_channel_status_request.cc

diff --git a/components/gcm_driver/gcm_channel_status_request.cc b/components/gcm_driver/gcm_channel_status_request.cc

index d609f5506bd3690bfe1603f158537413b607faf7..3cdf3ec0b7197eedc1f3ae07c702459f0dfdc4ba 100644

--- a/components/gcm_driver/gcm_channel_status_request.cc

+++ b/components/gcm_driver/gcm_channel_status_request.cc

@@ -64,8 +64,8 @@ void GCMChannelStatusRequest::Start() {

NOTREACHED();

}

- url_fetcher_.reset(

- net::URLFetcher::Create(request_url, net::URLFetcher::POST, this));

+ url_fetcher_ =

+ net::URLFetcher::Create(request_url, net::URLFetcher::POST, this);

url_fetcher_->SetRequestContext(request_context_getter_.get());

url_fetcher_->AddExtraRequestHeader("User-Agent: " + user_agent_);

url_fetcher_->SetUploadData(kRequestContentType, upload_data);