components/feedback/feedback_uploader_chrome.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feedback/feedback_uploader_chrome.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/devtools_ui.cc ('K') | « components/enhanced_bookmarks/bookmark_server_search_service.cc ('k') | components/gcm_driver/gcm_channel_status_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/feedback/feedback_uploader_chrome.cc

diff --git a/components/feedback/feedback_uploader_chrome.cc b/components/feedback/feedback_uploader_chrome.cc

index e5a52b13c87de5ed889aad477ffd2c7030ead528..aea651f4244b46815299a4b2f50bee45a6b55535 100644

--- a/components/feedback/feedback_uploader_chrome.cc

+++ b/components/feedback/feedback_uploader_chrome.cc

@@ -46,12 +46,14 @@ void FeedbackUploaderChrome::DispatchReport(const std::string& data) {

GURL post_url(url_);

// Note: FeedbackUploaderDelegate deletes itself and the fetcher.

- net::URLFetcher* fetcher = net::URLFetcher::Create(

- post_url, net::URLFetcher::POST,

- new FeedbackUploaderDelegate(

- data,

- base::Bind(&FeedbackUploaderChrome::UpdateUploadTimer, AsWeakPtr()),

- base::Bind(&FeedbackUploaderChrome::RetryReport, AsWeakPtr())));

+ net::URLFetcher* fetcher =

+ net::URLFetcher::Create(

+ post_url, net::URLFetcher::POST,

+ new FeedbackUploaderDelegate(

+ data, base::Bind(&FeedbackUploaderChrome::UpdateUploadTimer,

+ AsWeakPtr()),

+ base::Bind(&FeedbackUploaderChrome::RetryReport, AsWeakPtr())))

+ .release();

// Tell feedback server about the variation state of this install.

net::HttpRequestHeaders headers;