chrome/browser/ui/app_list/start_page_service.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/start_page_service.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/spellchecker/spelling_service_client.cc ('K') | « chrome/browser/ui/app_list/search/common/url_icon_source.cc ('k') | chrome/browser/ui/omnibox/omnibox_navigation_observer.cc » ('j') | chrome/browser/ui/webui/devtools_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/start_page_service.cc

diff --git a/chrome/browser/ui/app_list/start_page_service.cc b/chrome/browser/ui/app_list/start_page_service.cc

index 8482ebc116c0e596e257afbecf9a8f863e0390a0..25358f1fc5170f5d13a92d3ab481c72a78f15753 100644

--- a/chrome/browser/ui/app_list/start_page_service.cc

+++ b/chrome/browser/ui/app_list/start_page_service.cc

@@ -623,8 +623,8 @@ void StartPageService::FetchDoodleJson() {

GURL google_base_url(UIThreadSearchTermsData(profile_).GoogleBaseURLValue());

GURL doodle_url = google_base_url.ReplaceComponents(replacements);

- doodle_fetcher_.reset(

- net::URLFetcher::Create(0, doodle_url, net::URLFetcher::GET, this));

+ doodle_fetcher_ =

+ net::URLFetcher::Create(0, doodle_url, net::URLFetcher::GET, this);

doodle_fetcher_->SetRequestContext(profile_->GetRequestContext());

doodle_fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES);

doodle_fetcher_->Start();