chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/spellchecker/spelling_service_client.cc ('K') | « chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc ('k') | chrome/browser/supervised_user/experimental/supervised_user_async_url_checker.cc » ('j') | chrome/browser/ui/webui/devtools_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc

diff --git a/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc b/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc

index ac27806ecc6e9d0c1865b796e377e070f0b13ab9..0f868f453845582701d4b5c5ebfe53f8d8553a38 100644

--- a/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc

+++ b/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc

@@ -174,10 +174,8 @@ void PermissionRequestCreatorApiary::OnGetTokenSuccess(

DCHECK(it != requests_.end());

(*it)->access_token = access_token;

- (*it)->url_fetcher.reset(URLFetcher::Create((*it)->url_fetcher_id,

- GetApiUrl(),

- URLFetcher::POST,

- this));

+ (*it)->url_fetcher = URLFetcher::Create((*it)->url_fetcher_id, GetApiUrl(),

+ URLFetcher::POST, this);

(*it)->url_fetcher->SetRequestContext(context_);

(*it)->url_fetcher->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |