Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6168)

Unified Diff: chrome/browser/safe_browsing/protocol_manager.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/protocol_manager.cc
diff --git a/chrome/browser/safe_browsing/protocol_manager.cc b/chrome/browser/safe_browsing/protocol_manager.cc
index 234a0e7966442771470928a16c6908c5deebf94d..e8b55e16883bcec32d81551e61e5914192782ff0 100644
--- a/chrome/browser/safe_browsing/protocol_manager.cc
+++ b/chrome/browser/safe_browsing/protocol_manager.cc
@@ -183,8 +183,9 @@ void SafeBrowsingProtocolManager::GetFullHash(
return;
}
GURL gethash_url = GetHashUrl();
- net::URLFetcher* fetcher = net::URLFetcher::Create(
- url_fetcher_id_++, gethash_url, net::URLFetcher::POST, this);
+ net::URLFetcher* fetcher =
+ net::URLFetcher::Create(url_fetcher_id_++, gethash_url,
+ net::URLFetcher::POST, this).release();
Ryan Sleevi 2015/04/30 18:23:44 line 189
hash_requests_[fetcher] = FullHashDetails(callback, is_download);
const std::string get_hash = safe_browsing::FormatGetHash(prefixes);
@@ -557,8 +558,8 @@ bool SafeBrowsingProtocolManager::IssueBackupUpdateRequest(
backup_update_reason_ = backup_update_reason;
GURL backup_update_url = BackupUpdateUrl(backup_update_reason);
- request_.reset(net::URLFetcher::Create(
- url_fetcher_id_++, backup_update_url, net::URLFetcher::POST, this));
+ request_ = net::URLFetcher::Create(url_fetcher_id_++, backup_update_url,
+ net::URLFetcher::POST, this);
request_->SetLoadFlags(net::LOAD_DISABLE_CACHE);
request_->SetRequestContext(request_context_getter_.get());
request_->SetUploadData("text/plain", update_list_data_);
@@ -584,8 +585,8 @@ void SafeBrowsingProtocolManager::IssueChunkRequest() {
DCHECK(!next_chunk.url.empty());
GURL chunk_url = NextChunkUrl(next_chunk.url);
request_type_ = CHUNK_REQUEST;
- request_.reset(net::URLFetcher::Create(
- url_fetcher_id_++, chunk_url, net::URLFetcher::GET, this));
+ request_ = net::URLFetcher::Create(url_fetcher_id_++, chunk_url,
+ net::URLFetcher::GET, this);
request_->SetLoadFlags(net::LOAD_DISABLE_CACHE);
request_->SetRequestContext(request_context_getter_.get());
chunk_request_start_ = base::Time::Now();
@@ -635,8 +636,8 @@ void SafeBrowsingProtocolManager::OnGetChunksComplete(
UMA_HISTOGRAM_COUNTS("SB2.UpdateRequestSize", update_list_data_.size());
GURL update_url = UpdateUrl();
- request_.reset(net::URLFetcher::Create(
- url_fetcher_id_++, update_url, net::URLFetcher::POST, this));
+ request_ = net::URLFetcher::Create(url_fetcher_id_++, update_url,
+ net::URLFetcher::POST, this);
request_->SetLoadFlags(net::LOAD_DISABLE_CACHE);
request_->SetRequestContext(request_context_getter_.get());
request_->SetUploadData("text/plain", update_list_data_);

Powered by Google App Engine
This is Rietveld 408576698