Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: chrome/browser/safe_browsing/ping_manager.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/ping_manager.cc
diff --git a/chrome/browser/safe_browsing/ping_manager.cc b/chrome/browser/safe_browsing/ping_manager.cc
index 86b29d326723b978ad06a2c16646f531dea1471f..fb0a2d14a3c79ff8c2a26da4b485c0a48646c3a8 100644
--- a/chrome/browser/safe_browsing/ping_manager.cc
+++ b/chrome/browser/safe_browsing/ping_manager.cc
@@ -95,10 +95,11 @@ void SafeBrowsingPingManager::ReportSafeBrowsingHit(
GURL report_url = SafeBrowsingHitUrl(malicious_url, page_url,
referrer_url, is_subresource,
threat_type);
- net::URLFetcher* report = net::URLFetcher::Create(
- report_url,
- post_data.empty() ? net::URLFetcher::GET : net::URLFetcher::POST,
- this);
+ net::URLFetcher* report =
+ net::URLFetcher::Create(
+ report_url,
+ post_data.empty() ? net::URLFetcher::GET : net::URLFetcher::POST,
+ this).release();
Ryan Sleevi 2015/04/30 18:23:44 line 107
report->SetLoadFlags(net::LOAD_DISABLE_CACHE);
report->SetRequestContext(request_context_getter_.get());
if (!post_data.empty())
@@ -111,8 +112,9 @@ void SafeBrowsingPingManager::ReportSafeBrowsingHit(
void SafeBrowsingPingManager::ReportMalwareDetails(
const std::string& report) {
GURL report_url = MalwareDetailsUrl();
- net::URLFetcher* fetcher = net::URLFetcher::Create(
- report_url, net::URLFetcher::POST, this);
+ net::URLFetcher* fetcher =
+ net::URLFetcher::Create(report_url, net::URLFetcher::POST, this)
+ .release();
Ryan Sleevi 2015/04/30 18:23:44 line 124
fetcher->SetLoadFlags(net::LOAD_DISABLE_CACHE);
fetcher->SetRequestContext(request_context_getter_.get());
fetcher->SetUploadData("application/octet-stream", report);

Powered by Google App Engine
This is Rietveld 408576698