chrome/browser/safe_browsing/malware_details_cache.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/malware_details_cache.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/client_side_detection_service.cc ('K') | « chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.cc ('k') | chrome/browser/safe_browsing/ping_manager.cc » ('j') | chrome/browser/safe_browsing/ping_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/malware_details_cache.cc

diff --git a/chrome/browser/safe_browsing/malware_details_cache.cc b/chrome/browser/safe_browsing/malware_details_cache.cc

index dc5fbc54b4464cc4047f2a7669993a3384580f87..4e8ae121d7dd67606845626734214a5678f7aea4 100644

--- a/chrome/browser/safe_browsing/malware_details_cache.cc

+++ b/chrome/browser/safe_browsing/malware_details_cache.cc

@@ -78,8 +78,8 @@ void MalwareDetailsCacheCollector::OpenEntry() {

return;

}

- current_fetch_.reset(net::URLFetcher::Create(

- GURL(resources_it_->first), net::URLFetcher::GET, this));

+ current_fetch_ = net::URLFetcher::Create(GURL(resources_it_->first),

+ net::URLFetcher::GET, this);

current_fetch_->SetRequestContext(request_context_getter_.get());

// Only from cache, and don't save cookies.

current_fetch_->SetLoadFlags(net::LOAD_ONLY_FROM_CACHE |