chrome/browser/chromeos/attestation/attestation_ca_client.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/attestation/attestation_ca_client.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/bitmap_fetcher/bitmap_fetcher.cc ('k') | chrome/browser/chromeos/customization/customization_document.cc » ('j') | chrome/browser/chromeos/policy/cloud_external_data_manager_base_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/attestation/attestation_ca_client.cc

diff --git a/chrome/browser/chromeos/attestation/attestation_ca_client.cc b/chrome/browser/chromeos/attestation/attestation_ca_client.cc

index 4a9aca67f7c71d47b0f6587f5948bdafd3c51b78..ab1ae86eaa6702a38f784ccbb5bbd62fec3e445f 100644

--- a/chrome/browser/chromeos/attestation/attestation_ca_client.cc

+++ b/chrome/browser/chromeos/attestation/attestation_ca_client.cc

@@ -77,10 +77,9 @@ void AttestationCAClient::FetchURL(const std::string& url,

const std::string& request,

const DataCallback& on_response) {

// The first argument allows the use of TestURLFetcherFactory in tests.

- net::URLFetcher* fetcher = net::URLFetcher::Create(0,

- GURL(url),

- net::URLFetcher::POST,

- this);

+ net::URLFetcher* fetcher =

+ net::URLFetcher::Create(0, GURL(url), net::URLFetcher::POST, this)

+ .release();

Ryan Sleevi 2015/04/30 18:23:44 Ideally, you'd move the .release() to line 88 and

fetcher->SetRequestContext(g_browser_process->system_request_context());

fetcher->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |

net::LOAD_DO_NOT_SAVE_COOKIES |