chrome/browser/autocomplete/zero_suggest_provider.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/zero_suggest_provider.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/drive/drive_app_converter.cc ('k') | chrome/browser/bitmap_fetcher/bitmap_fetcher.cc » ('j') | chrome/browser/chromeos/attestation/attestation_ca_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/zero_suggest_provider.cc

diff --git a/chrome/browser/autocomplete/zero_suggest_provider.cc b/chrome/browser/autocomplete/zero_suggest_provider.cc

index bb9f4607410d2fdae9cc2636ac15396a9b823eb4..3df4f4d66366ef746c2d7d22e2e5c5ae650fe64b 100644

--- a/chrome/browser/autocomplete/zero_suggest_provider.cc

+++ b/chrome/browser/autocomplete/zero_suggest_provider.cc

@@ -330,10 +330,8 @@ void ZeroSuggestProvider::Run(const GURL& suggest_url) {

}

} else {

const int kFetcherID = 1;

- fetcher_.reset(

- net::URLFetcher::Create(kFetcherID,

- suggest_url,

- net::URLFetcher::GET, this));

+ fetcher_ = net::URLFetcher::Create(kFetcherID, suggest_url,

+ net::URLFetcher::GET, this);

fetcher_->SetRequestContext(profile_->GetRequestContext());

fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES);

// Add Chrome experiment state to the request headers.