chrome/browser/apps/drive/drive_app_converter.cc - Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/drive/drive_app_converter.cc

Issue 1117703002: Adjust URLFetcher::Create API so that object is returned as scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix another failure missed by my regex Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/drive/drive_app_converter.cc

diff --git a/chrome/browser/apps/drive/drive_app_converter.cc b/chrome/browser/apps/drive/drive_app_converter.cc

index b7a8c33839361ffe23e11350a3d7fb177faad904..e1df7c9e24b579a8dd8abea63e1434beea0c8158 100644

--- a/chrome/browser/apps/drive/drive_app_converter.cc

+++ b/chrome/browser/apps/drive/drive_app_converter.cc

@@ -44,8 +44,7 @@ class DriveAppConverter::IconFetcher : public net::URLFetcherDelegate,

~IconFetcher() override {}

void Start() {

- fetcher_.reset(

- net::URLFetcher::Create(icon_url_, net::URLFetcher::GET, this));

+ fetcher_ = net::URLFetcher::Create(icon_url_, net::URLFetcher::GET, this);

fetcher_->SetRequestContext(converter_->profile_->GetRequestContext());

fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES);

fetcher_->Start();

« no previous file with comments | « no previous file | chrome/browser/autocomplete/zero_suggest_provider.cc » ('j') | chrome/browser/chromeos/attestation/attestation_ca_client.cc » ('J')