Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1117443002: create GrTestUtils.h, move some common functions into it (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

create GrTestUtils.h, move some common functions into it BUG=skia: Committed: https://skia.googlesource.com/skia/+/4eaf9cef5a76098f78efac30beb966ac833d32c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -117 lines) Patch
M gyp/gpu.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M include/gpu/GrProcessorUnitTest.h View 2 chunks +1 line, -67 lines 0 comments Download
A include/gpu/GrTestUtils.h View 1 chunk +84 lines, -0 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
A src/gpu/GrTestUtils.cpp View 1 chunk +29 lines, -0 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
joshualitt
ptal
5 years, 7 months ago (2015-04-28 20:02:21 UTC) #2
bsalomon
lgtm
5 years, 7 months ago (2015-04-28 20:07:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117443002/1
5 years, 7 months ago (2015-04-28 20:27:21 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 20:31:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4eaf9cef5a76098f78efac30beb966ac833d32c2

Powered by Google App Engine
This is Rietveld 408576698