Issue 1117333002: Fix some static member emits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1117333002: Fix some static member emits (Closed)

Created:
5 years, 7 months ago by vsm

Modified:
5 years, 7 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix some static member emits Fixes: - Lazy static fields - Jmesserly's suggestion from a previous cl - Private named constructors (was failing at runtime in angular) R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/428c48b1ffb53daaa35c931a6c7254e26b280ad9

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -103 lines)			Patch
M	lib/runtime/dart/_internal.js	View		5 chunks	+4 lines, -5 lines	0 comments	Download
M	lib/runtime/dart/_isolate_helper.js	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	lib/runtime/dart/_native_typed_data.js	View		28 chunks	+71 lines, -75 lines	0 comments	Download
M	lib/runtime/dart/convert.js	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	lib/runtime/dart/core.js	View		8 chunks	+10 lines, -12 lines	0 comments	Download
M	lib/runtime/dart/typed_data.js	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	lib/src/codegen/js_codegen.dart	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

vsm

5 years, 7 months ago (2015-05-01 18:34:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
428c48b1ffb53daaa35c931a6c7254e26b280ad9 (presubmit successful).