Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1117333002: Fix some static member emits (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: reformat Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/typed_data.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/codegen/js_codegen.dart
diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart
index 0c9199c7f46c6969dd6918f2c7b413ca89946466..f6a4409b3b4dd3c88adb5b7bfad0d4a2a38ad03e 100644
--- a/lib/src/codegen/js_codegen.dart
+++ b/lib/src/codegen/js_codegen.dart
@@ -1051,7 +1051,8 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
if (element.enclosingElement is CompilationUnitElement &&
(element.library != libraryInfo.library ||
element is TopLevelVariableElement && !element.isConst)) {
- return js.call('#.#', [_libraryName(element.library), name]);
+ var memberName = _emitMemberName(name, isStatic: true);
+ return js.call('#.#', [_libraryName(element.library), memberName]);
}
// Unqualified class member. This could mean implicit-this, or implicit
@@ -1508,7 +1509,8 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
visitConstructorName(ConstructorName node) {
var typeName = _visit(node.type);
if (node.name != null) {
- return js.call('#.#', [typeName, _emitMemberName(node.name.name)]);
+ return js.call(
+ '#.#', [typeName, _emitMemberName(node.name.name, isStatic: true)]);
}
return typeName;
}
« no previous file with comments | « lib/runtime/dart/typed_data.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698