Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: README.chromium

Issue 111723007: Add support for icu_use_data_file=1 to icu.gyp on Windows (Closed) Base URL: svn://chrome-svn/chrome/trunk/deps/third_party/icu46/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android/icudt46l.dat » ('j') | icu.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.chromium
===================================================================
--- README.chromium (revision 239289)
+++ README.chromium (working copy)
@@ -180,9 +180,10 @@
(see http://bugs.icu-project.org/trac/ticket/10570 ) and run 'make' again.
- - source/data/in/icudt46l.dat : Built on Linux with all the patches
- above applied. This file will be generated in
- {BUILD_DIR_ROOT}/data/out/tmp.
+ - source/data/in/icudtl.dat : Built on Linux with all the patches
+ above applied. icudt46l.dat is generated in
+ {BUILD_DIR_ROOT}/data/out/tmp and copied to the above location with a
+ version number (46) dropped.
- windows/icudt.dll : With icudt46l.dat in place, all the patches applied
and header files moved (#11 below), generated by building icudt_build
@@ -192,13 +193,13 @@
dll name to avoind having to update our build scripts/configuration
files everytime ICU is upgraded to a new version.
- - {mac,linux}/icudt46l_dat.S : Built on Mac and Linux with all the
+ - {mac,linux}/icudt46l_dat.S : Built on Linux with all the
patches above (except android/brkitr.patch) applied and checked in.
This file will be generated in {BUILD_DIR_ROOT}/data/out/tmp.
- Alternatively, one can just generate icudt46l_dat.S on Linux and adopt
- the header portion to match the current header in mac/icudt46l_dat.S.
- That is as following without no leading space in each line:
+ mac/icudt46l_dat.S is identical to linux/icudt46l_dat.S. It's made
+ by changing the header portion of the Linux version to read as following
+ (no leading whitespace) :
.globl _icudt46_dat
#ifdef U_HIDE_DATA_SYMBOL
@@ -213,7 +214,11 @@
- android/icudt46l_dat.S : Built on Linux with all the patches above and
android/brkitr.patch applied and android/patch_locale.sh executed, and
checked in.
+ - android/icudtl.dat : Generated as icudt46l.dat in
+ {BUILD_DIR_ROOT}/data/out/tmp along with icudt46l_dat.S and
+ copied to the above location with '46' dropped in its name.
+
12. Apply the fix found with static analysis tools such as PSV and coverity
- patches/static.analysis.patch
« no previous file with comments | « no previous file | android/icudt46l.dat » ('j') | icu.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698