Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: README.chromium

Issue 111723007: Add support for icu_use_data_file=1 to icu.gyp on Windows (Closed) Base URL: svn://chrome-svn/chrome/trunk/deps/third_party/icu46/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | android/icudt46l.dat » ('j') | icu.gyp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Name: icu 1 Name: icu
2 URL: http://site.icu-project.org/ 2 URL: http://site.icu-project.org/
3 Version: 4.6 3 Version: 4.6
4 License: MIT 4 License: MIT
5 Security Critical: yes 5 Security Critical: yes
6 6
7 Description: 7 Description:
8 This directory contains the source code of ICU 4.6 for C/C++ 8 This directory contains the source code of ICU 4.6 for C/C++
9 9
10 1. It was obtained with the following: 10 1. It was obtained with the following:
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 173
174 'make' will fail in the 1st pass. Copy source/data/in/coll/invuca.icu 174 'make' will fail in the 1st pass. Copy source/data/in/coll/invuca.icu
175 to {BUILD_DIR_ROOT}/data/out/build/icudt46l/coll and re-run 'make' 175 to {BUILD_DIR_ROOT}/data/out/build/icudt46l/coll and re-run 'make'
176 in {BUILD_DIR_ROOT}/data. 176 in {BUILD_DIR_ROOT}/data.
177 177
178 'make' will fail again when pkgdata looks for css3transform.res. Edit 178 'make' will fail again when pkgdata looks for css3transform.res. Edit
179 data/out/tmp/icudata.lst to replace 'css3transform.res' with 'root.res'. 179 data/out/tmp/icudata.lst to replace 'css3transform.res' with 'root.res'.
180 (see http://bugs.icu-project.org/trac/ticket/10570 ) and run 'make' again. 180 (see http://bugs.icu-project.org/trac/ticket/10570 ) and run 'make' again.
181 181
182 182
183 - source/data/in/icudt46l.dat : Built on Linux with all the patches 183 - source/data/in/icudtl.dat : Built on Linux with all the patches
184 above applied. This file will be generated in 184 above applied. icudt46l.dat is generated in
185 {BUILD_DIR_ROOT}/data/out/tmp. 185 {BUILD_DIR_ROOT}/data/out/tmp and copied to the above location with a
186 version number (46) dropped.
186 187
187 - windows/icudt.dll : With icudt46l.dat in place, all the patches applied 188 - windows/icudt.dll : With icudt46l.dat in place, all the patches applied
188 and header files moved (#11 below), generated by building icudt_build 189 and header files moved (#11 below), generated by building icudt_build
189 project of build/icudt_build.sln on Windows. icudt46.dll is 190 project of build/icudt_build.sln on Windows. icudt46.dll is
190 generated in bin/{Release,Debug} and copied to windows/icudt.dll 191 generated in bin/{Release,Debug} and copied to windows/icudt.dll
191 and checked in. Note that we drop the version number ('46') from the 192 and checked in. Note that we drop the version number ('46') from the
192 dll name to avoind having to update our build scripts/configuration 193 dll name to avoind having to update our build scripts/configuration
193 files everytime ICU is upgraded to a new version. 194 files everytime ICU is upgraded to a new version.
194 195
195 - {mac,linux}/icudt46l_dat.S : Built on Mac and Linux with all the 196 - {mac,linux}/icudt46l_dat.S : Built on Linux with all the
196 patches above (except android/brkitr.patch) applied and checked in. 197 patches above (except android/brkitr.patch) applied and checked in.
197 This file will be generated in {BUILD_DIR_ROOT}/data/out/tmp. 198 This file will be generated in {BUILD_DIR_ROOT}/data/out/tmp.
198 199
199 Alternatively, one can just generate icudt46l_dat.S on Linux and adopt 200 mac/icudt46l_dat.S is identical to linux/icudt46l_dat.S. It's made
200 the header portion to match the current header in mac/icudt46l_dat.S. 201 by changing the header portion of the Linux version to read as following
201 That is as following without no leading space in each line: 202 (no leading whitespace) :
202 203
203 .globl _icudt46_dat 204 .globl _icudt46_dat
204 #ifdef U_HIDE_DATA_SYMBOL 205 #ifdef U_HIDE_DATA_SYMBOL
205 .private_extern _icudt46_dat 206 .private_extern _icudt46_dat
206 #endif 207 #endif
207 .data 208 .data
208 .const 209 .const
209 .align 4 210 .align 4
210 _icudt46_dat: 211 _icudt46_dat:
211 212
212 213
213 - android/icudt46l_dat.S : Built on Linux with all the patches above and 214 - android/icudt46l_dat.S : Built on Linux with all the patches above and
214 android/brkitr.patch applied and android/patch_locale.sh executed, and 215 android/brkitr.patch applied and android/patch_locale.sh executed, and
215 checked in. 216 checked in.
217 - android/icudtl.dat : Generated as icudt46l.dat in
218 {BUILD_DIR_ROOT}/data/out/tmp along with icudt46l_dat.S and
219 copied to the above location with '46' dropped in its name.
220
216 221
217 12. Apply the fix found with static analysis tools such as PSV and coverity 222 12. Apply the fix found with static analysis tools such as PSV and coverity
218 223
219 - patches/static.analysis.patch 224 - patches/static.analysis.patch
220 - upstream trunk/4.8 do not have this code any more. 225 - upstream trunk/4.8 do not have this code any more.
221 226
222 13. Fix for msvs2010 applied: 227 13. Fix for msvs2010 applied:
223 --- D:/src/ent/src/third_party/icu/source/common/stringpiece.cpp 228 --- D:/src/ent/src/third_party/icu/source/common/stringpiece.cpp
224 (revision 78292) 229 (revision 78292)
225 +++ D:/src/ent/src/third_party/icu/source/common/stringpiece.cpp 230 +++ D:/src/ent/src/third_party/icu/source/common/stringpiece.cpp
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 24. Fix compilation errors on VS2012 and above. 289 24. Fix compilation errors on VS2012 and above.
285 - patches/vs2012.patch 290 - patches/vs2012.patch
286 291
287 25. Fix a buffer overflow in UTF-16/32 detection. 292 25. Fix a buffer overflow in UTF-16/32 detection.
288 - patches/csetdet.patch 293 - patches/csetdet.patch
289 - upstream bug: http://bugs.icu-project.org/trac/ticket/10318 294 - upstream bug: http://bugs.icu-project.org/trac/ticket/10318
290 295
291 26. Add BreakIterator::getRuleStatus 296 26. Add BreakIterator::getRuleStatus
292 - patches/breakiterator.patch 297 - patches/breakiterator.patch
293 - Copy and paste BreakIterator::getRuleStatus API from ICU 52 298 - Copy and paste BreakIterator::getRuleStatus API from ICU 52
OLDNEW
« no previous file with comments | « no previous file | android/icudt46l.dat » ('j') | icu.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698