Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4125)

Unified Diff: chrome/browser/ssl/ssl_cert_reporter.h

Issue 1117173004: Split cert reporter class into report building/serializing and sending (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: BUILD.gn fix Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_cert_reporter.h
diff --git a/chrome/browser/ssl/ssl_cert_reporter.h b/chrome/browser/ssl/ssl_cert_reporter.h
index d31c08018cbc19f8ba11feabb4081421cb303fd9..03864aa80aaa1999d8426b08e80c79bbd22efc2e 100644
--- a/chrome/browser/ssl/ssl_cert_reporter.h
+++ b/chrome/browser/ssl/ssl_cert_reporter.h
@@ -17,11 +17,10 @@ class SSLCertReporter {
public:
virtual ~SSLCertReporter() {}
- // Send a report for |hostname| with the given |ssl_info| to the
- // report collection endpoint. |callback| will be run when the report has
- // been sent off (not necessarily after a response has been received).
eroman 2015/05/12 00:27:52 I assume the reference to |callback| was obsolete?
estark 2015/05/12 20:42:16 Yes, that's right.
- virtual void ReportInvalidCertificateChain(const std::string& hostname,
- const net::SSLInfo& ssl_info) = 0;
+ // Send a serialized certificate report to the report collection
eroman 2015/05/12 00:27:52 Sends
+ // endpoint.
+ virtual void ReportInvalidCertificateChain(
+ const std::string& serialized_report) = 0;
};
#endif // CHROME_BROWSER_SSL_SSL_CERT_REPORTER_H_

Powered by Google App Engine
This is Rietveld 408576698