Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: chrome/browser/ssl/ssl_cert_reporter.h

Issue 1117173004: Split cert reporter class into report building/serializing and sending (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: BUILD.gn fix Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SSL_SSL_CERT_REPORTER_H_ 5 #ifndef CHROME_BROWSER_SSL_SSL_CERT_REPORTER_H_
6 #define CHROME_BROWSER_SSL_SSL_CERT_REPORTER_H_ 6 #define CHROME_BROWSER_SSL_SSL_CERT_REPORTER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 namespace net { 10 namespace net {
11 class SSLInfo; 11 class SSLInfo;
12 } // namespace net 12 } // namespace net
13 13
14 // An interface used by interstitial pages to send reports of invalid 14 // An interface used by interstitial pages to send reports of invalid
15 // certificate chains. 15 // certificate chains.
16 class SSLCertReporter { 16 class SSLCertReporter {
17 public: 17 public:
18 virtual ~SSLCertReporter() {} 18 virtual ~SSLCertReporter() {}
19 19
20 // Send a report for |hostname| with the given |ssl_info| to the 20 // Send a serialized certificate report to the report collection
eroman 2015/05/12 00:27:52 Sends
21 // report collection endpoint. |callback| will be run when the report has 21 // endpoint.
22 // been sent off (not necessarily after a response has been received). 22 virtual void ReportInvalidCertificateChain(
eroman 2015/05/12 00:27:52 I assume the reference to |callback| was obsolete?
estark 2015/05/12 20:42:16 Yes, that's right.
23 virtual void ReportInvalidCertificateChain(const std::string& hostname, 23 const std::string& serialized_report) = 0;
24 const net::SSLInfo& ssl_info) = 0;
25 }; 24 };
26 25
27 #endif // CHROME_BROWSER_SSL_SSL_CERT_REPORTER_H_ 26 #endif // CHROME_BROWSER_SSL_SSL_CERT_REPORTER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698