tools/clang/plugins/FindBadConstructsConsumer.h - Issue 1117163002: Clang style plugin: add warn-only option and use it on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/FindBadConstructsConsumer.h

Issue 1117163002: Clang style plugin: add warn-only option and use it on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/clang/plugins/FindBadConstructsAction.cpp ('K') | « tools/clang/plugins/FindBadConstructsAction.cpp ('k') | tools/clang/plugins/FindBadConstructsConsumer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/plugins/FindBadConstructsConsumer.h

diff --git a/tools/clang/plugins/FindBadConstructsConsumer.h b/tools/clang/plugins/FindBadConstructsConsumer.h

index 6e2b2c9234265665bc47a0a2bcba1521518bc04d..c52a8f33a78ca880ba3f42ec9d5738685c5b7856 100644

--- a/tools/clang/plugins/FindBadConstructsConsumer.h

+++ b/tools/clang/plugins/FindBadConstructsConsumer.h

@@ -71,7 +71,6 @@ class FindBadConstructsConsumer

static RefcountIssue CheckRecordForRefcountIssue(

const clang::CXXRecordDecl* record,

clang::SourceLocation& loc);

- clang::DiagnosticsEngine::Level getErrorLevel();

static bool IsRefCountedCallback(const clang::CXXBaseSpecifier* base,

clang::CXXBasePath& path,

void* user_data);

@@ -86,8 +85,6 @@ class FindBadConstructsConsumer

void CheckWeakPtrFactoryMembers(clang::SourceLocation record_location,

clang::CXXRecordDecl* record);

- const Options options_;

unsigned diag_method_requires_override_;

unsigned diag_redundant_virtual_specifier_;

unsigned diag_base_method_virtual_and_final_;