Clang style plugin: add warn-only option and use it on Windows

tools/clang/plugins/FindBadConstructsAction.cpp

Index: tools/clang/plugins/FindBadConstructsAction.cpp
diff --git a/tools/clang/plugins/FindBadConstructsAction.cpp b/tools/clang/plugins/FindBadConstructsAction.cpp
index 6c39d724b1a7a476287ce4d48365f8732374dbdd..812508410ec3e6245df4c05538fe0ac93662bde6 100644
--- a/tools/clang/plugins/FindBadConstructsAction.cpp
+++ b/tools/clang/plugins/FindBadConstructsAction.cpp
@@ -57,6 +57,8 @@ bool FindBadConstructsAction::ParseArgs(const CompilerInstance& instance,
       options_.with_ast_visitor = true;
     } else if (args[i] == "check-templates") {
       options_.check_templates = true;
+    } else if (args[i] == "warn-only") {
+      options_.warn_only = true;

[Nico, 2015/04/30 23:08:04]

I'd make this block windows-only

[hans, 2015/04/30 23:13:32]

that's ok)

I like that test. It found the bug when I hadn't updated both functions where we
computed the error level.

I want to keep the test so I'd rather not make the flag windows-only.

     } else {
       parsed = false;
       llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n";