[Effen] Port fn.dart from the legacy sky.Node backend to the RenderNode backend, which is currently…

[Effen] Port fn.dart from the legacy sky.Node backend to the RenderNode backend, which is currently just a sky.Node-backed shim, but will eventually be the core Sky interface for layout and painting.

- the custom layout class in fn is removed by this patch; a new class
  will be added in a later CL

- the version of layout.dart in this CL is a subset of what we're
  targetting on the long run with
     https://codereview.chromium.org/1093633002

- a couple of lines of dead code are removed in this CL also

R=eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/21a922fa23e70a2ad3d97008bd51180ded615ddf

[eseidel, 2015-05-08 19:15:52]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2015-05-08 19:15:54]

https://codereview.chromium.org/1117143003/diff/1/sky/framework/layout.dart
File sky/framework/layout.dart (right):

https://codereview.chromium.org/1117143003/diff/1/sky/framework/layout.dart#n...
sky/framework/layout.dart:65: ParentData pos;
parentData or something more readable than "pos"?

https://codereview.chromium.org/1117143003/diff/1/sky/framework/layout.dart#n...
sky/framework/layout.dart:68: if (child.pos is! ParentData)
is!?

https://codereview.chromium.org/1117143003/diff/1/sky/framework/layout.dart#n...
sky/framework/layout.dart:385: var r = '';
result?

https://codereview.chromium.org/1117143003/diff/1/sky/framework/layout.dart#n...
sky/framework/layout.dart:400: for (var child in children)
is var needed?  Should this be a type?

https://codereview.chromium.org/1117143003/diff/1/sky/framework/node.dart
File sky/framework/node.dart (right):

https://codereview.chromium.org/1117143003/diff/1/sky/framework/node.dart#new...
sky/framework/node.dart:25: void redepthChildren() { // internal, do not call
_redepthChildren?

[Hixie, 2015-05-08 19:39:17]

https://codereview.chromium.org/1117143003/diff/1/sky/framework/layout.dart
File sky/framework/layout.dart (right):

https://codereview.chromium.org/1117143003/diff/1/sky/framework/layout.dart#n...
sky/framework/layout.dart:65: ParentData pos;
On 2015/05/08 19:15:53, eseidel wrote:
> parentData or something more readable than "pos"?

I don't know that it'd be any more readable, but have a look at the new
changeset.

https://codereview.chromium.org/1117143003/diff/1/sky/framework/layout.dart#n...
sky/framework/layout.dart:68: if (child.pos is! ParentData)
On 2015/05/08 19:15:54, eseidel wrote:
> is!?

Dart for "is not".

https://codereview.chromium.org/1117143003/diff/1/sky/framework/layout.dart#n...
sky/framework/layout.dart:385: var r = '';
On 2015/05/08 19:15:54, eseidel wrote:
> result?

Changed.

https://codereview.chromium.org/1117143003/diff/1/sky/framework/layout.dart#n...
sky/framework/layout.dart:400: for (var child in children)
On 2015/05/08 19:15:53, eseidel wrote:
> is var needed?  Should this be a type?

Either var or a type is needed. The way this function is written, it's agnostic
about what the type is, though.

https://codereview.chromium.org/1117143003/diff/1/sky/framework/node.dart
File sky/framework/node.dart (right):

https://codereview.chromium.org/1117143003/diff/1/sky/framework/node.dart#new...
sky/framework/node.dart:25: void redepthChildren() { // internal, do not call
On 2015/05/08 19:15:54, eseidel wrote:
> _redepthChildren?

You need to be able to override it in subclasses.

[eseidel, 2015-05-08 19:53:47]

lgtm

[Hixie, 2015-05-08 20:06:58]

Committed patchset #3 (id:40001) manually as
21a922fa23e70a2ad3d97008bd51180ded615ddf (presubmit successful).