Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1117143002: Revert of Adding strict mode for bookmark_manager file for better error checking. (Closed)

Created:
5 years, 7 months ago by Dan Beam
Modified:
5 years, 7 months ago
Reviewers:
Bernhard Bauer, Deepak
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding strict mode for bookmark_manager file for better error checking. (patchset #1 id:1 of https://codereview.chromium.org/1115683002/) Reason for revert: > LGTM assuming this doesn't trigger any errors :) It did on the closure bots. Given that this change is solely about better error checking and it's hampering our ability to do compile-time checking with closure compiler, I'm reverting. deepak.m1@: you may consider adding these statement inside of a scope (e.g. inside cr.define()) as we do a lot of file concatenation and some files might not work with strict mode. Here's how you check if closure compiler likes your change locally: https://code.google.com/p/chromium/wiki/ClosureCompilation Original issue's description: > Adding strict mode for bookmark_manager file for better error checking. > > Adding strict mode to bookmark manager's js files to detect error at load time itself. > > BUG=177166 > > Committed: https://crrev.com/66c786a59403f02dc49df0090cece8e0e3cc3b1b > Cr-Commit-Position: refs/heads/master@{#327679} TBR=bauerb@chromium.org,deepak.m1@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=177166 Committed: https://crrev.com/55ca7b8160d679f0662e9e205824ae1a53f87a5c Cr-Commit-Position: refs/heads/master@{#327819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/resources/bookmark_manager/js/bmm.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/bookmark_manager/js/main.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
Created Revert of Adding strict mode for bookmark_manager file for better error checking.
5 years, 7 months ago (2015-04-30 22:29:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117143002/1
5 years, 7 months ago (2015-04-30 22:30:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 22:41:00 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 22:41:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55ca7b8160d679f0662e9e205824ae1a53f87a5c
Cr-Commit-Position: refs/heads/master@{#327819}

Powered by Google App Engine
This is Rietveld 408576698