Issue 1117063005: Remove FileSystem runtime flag for blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1117063005: Remove FileSystem runtime flag for blink (Closed)

Created:
5 years, 7 months ago by qiankun

Modified:
5 years, 7 months ago

Reviewers:
michaeln, Mike West, Torne

CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, kinuko+fileapi, kozyatinskiy+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, nhiroki, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, tzik, yurys+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove FileSystem runtime flag for blink This feature is in stable status since 2013. It should be fine to remove this runtime flag. The chromium side patch is at: https://codereview.chromium.org/1117953005/ BUG=402536

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -21 lines)			Patch
M	Source/modules/filesystem/DevToolsHostFileSystem.idl	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/modules/filesystem/HTMLInputElementFileSystem.idl	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/modules/filesystem/WindowFileSystem.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/modules/filesystem/WorkerGlobalScopeFileSystem.idl	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	Source/platform/RuntimeEnabledFeatures.in	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/WebRuntimeFeatures.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	public/web/WebRuntimeFeatures.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Torne

5 years, 7 months ago (2015-05-05 08:48:48 UTC) #5

not LGTM, see my comments on chromium side patch
(https://codereview.chromium.org/1117953005/) - this is still used by webview.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages