Devtools: Refactor color picker to use WI.installDragHandle()

Devtools: Refactor color picker to use WI.installDragHandle()

This change removes the color pickers drag handling code and reuses the WI.installDragHandle() method. It also removes the shift drag behavior on the color drag.

BUG=477974
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195575

[samli, 2015-05-05 06:45:03]

samli@chromium.org changed reviewers:
+ lushnikov@chromium.org

[lushnikov, 2015-05-07 15:50:33]

Why do we remove shift-drag behavior? I've heard people found it useful.

[lushnikov, 2015-05-07 16:02:26]

https://codereview.chromium.org/1116933007/diff/20001/Source/devtools/front_e...
File Source/devtools/front_end/elements/Spectrum.js (right):

https://codereview.chromium.org/1116933007/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/elements/Spectrum.js:92:
WebInspector.installDragHandle(this._draggerElement, colorDragStart.bind(this),
colorDrag.bind(this), null, "default");
can we rename draggerElement into colorElement while we are here?

https://codereview.chromium.org/1116933007/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/elements/Spectrum.js:102: this._originalColor =
this._hsv.slice(0);
.slice()

[samli, 2015-05-08 01:43:40]

https://codereview.chromium.org/1116933007/diff/20001/Source/devtools/front_e...
File Source/devtools/front_end/elements/Spectrum.js (right):

https://codereview.chromium.org/1116933007/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/elements/Spectrum.js:92:
WebInspector.installDragHandle(this._draggerElement, colorDragStart.bind(this),
colorDrag.bind(this), null, "default");
On 2015/05/07 16:02:26, lushnikov wrote:
> can we rename draggerElement into colorElement while we are here?

Done.

https://codereview.chromium.org/1116933007/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/elements/Spectrum.js:102: this._originalColor =
this._hsv.slice(0);
On 2015/05/07 16:02:26, lushnikov wrote:
> .slice()

Done.

[lushnikov, 2015-05-08 10:11:10]

>> Why do we remove shift-drag behavior? I've heard people found it useful.

What about this? Is it proved to be unneeded?

[samli, 2015-05-08 10:24:09]

On 2015/05/08 at 10:11:10, lushnikov wrote:
> >> Why do we remove shift-drag behavior? I've heard people found it useful.
> 
> What about this? Is it proved to be unneeded?

I asked Paul about this and he was unaware of what this even did. My opinion is
that it doesn't seem to be useful, is superseded by HSL representation
manipulation and is not discoverable.

I do not have proof this is useful or unuseful.

[lushnikov, 2015-05-12 09:09:47]

On 2015/05/08 10:24:09, samli wrote:
> On 2015/05/08 at 10:11:10, lushnikov wrote:
> > >> Why do we remove shift-drag behavior? I've heard people found it useful.
> > 
> > What about this? Is it proved to be unneeded?
> 
> I asked Paul about this and he was unaware of what this even did. My opinion
is
> that it doesn't seem to be useful, is superseded by HSL representation
> manipulation and is not discoverable.
> 
> I do not have proof this is useful or unuseful.

lgtm.

However, I've heard from @pfeldman about shift-drag usefulness, so let's also
get his approval here for
regressing this.

[pfeldman, 2015-05-12 09:29:23]

I like the shift-drag, furthermore, it might actually be handy in other places
that support drag'n'drop.

[samli, 2015-05-15 03:55:17]

On 2015/05/12 at 09:29:23, pfeldman wrote:
> I like the shift-drag, furthermore, it might actually be handy in other places
that support drag'n'drop.

Does anyone else like this? As I said before, I think this is adequately
superceded by HSL.

"it might actually be handy in other places that support drag'n'drop" I don't
understand this sentence.

[pfeldman, 2015-05-15 05:25:26]

On 2015/05/15 03:55:17, samli wrote:
> On 2015/05/12 at 09:29:23, pfeldman wrote:
> > I like the shift-drag, furthermore, it might actually be handy in other
places
> that support drag'n'drop.
> 
> Does anyone else like this? As I said before, I think this is adequately
> superceded by HSL.
> 
> "it might actually be handy in other places that support drag'n'drop" I don't
> understand this sentence.

Would it make sense for the bezier editor?

[samli, 2015-05-18 01:43:00]

On 2015/05/15 at 05:25:26, pfeldman wrote:
> On 2015/05/15 03:55:17, samli wrote:
> > On 2015/05/12 at 09:29:23, pfeldman wrote:
> > > I like the shift-drag, furthermore, it might actually be handy in other
places
> > that support drag'n'drop.
> > 
> > Does anyone else like this? As I said before, I think this is adequately
> > superceded by HSL.
> > 
> > "it might actually be handy in other places that support drag'n'drop" I
don't
> > understand this sentence.
> 
> Would it make sense for the bezier editor?

No.

[samli, 2015-05-20 01:27:08]

ping, not sure whether I can land this or not.

[pfeldman, 2015-05-20 01:31:27]

Feel free to land, we'll re-create it. It does not work as is anyways.

[samli, 2015-05-20 01:36:12]

The CQ bit was checked by samli@chromium.org

[commit-bot: I haz the power, 2015-05-20 01:37:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1116933007/40001

[commit-bot: I haz the power, 2015-05-20 03:04:31]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195575