Source/modules/notifications/Notification.cpp - Issue 1116843002: v8::Isolate* should be the first parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/Notification.cpp

Issue 1116843002: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed Mac compilation error for v8::Isolate* should be the first parameter patch Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/notifications/Notification.cpp

diff --git a/Source/modules/notifications/Notification.cpp b/Source/modules/notifications/Notification.cpp

index 227238ee3de57445545df040d126cc92a36323a5..72638ba4ea829c4cdff4694510ce411116331894 100644

--- a/Source/modules/notifications/Notification.cpp

+++ b/Source/modules/notifications/Notification.cpp

@@ -87,7 +87,7 @@ Notification* Notification::create(ExecutionContext* context, const String& titl

RefPtr<SerializedScriptValue> data;

if (options.hasData()) {

- data = SerializedScriptValueFactory::instance().create(options.data(), nullptr, exceptionState, options.data().isolate());

+ data = SerializedScriptValueFactory::instance().create(options.data().isolate(), options.data(), nullptr, exceptionState);

if (exceptionState.hadException())

return nullptr;

}