Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2413)

Unified Diff: base/barrier_closure.cc

Issue 1116833002: Fixed member use after destruction in BarrierClosure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/barrier_closure_unittest.cc » ('j') | base/barrier_closure_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/barrier_closure.cc
diff --git a/base/barrier_closure.cc b/base/barrier_closure.cc
index 1b77429ae3f3041294f89d77ffb00a76075e1355..d870fcf28be7cbc437fbf90f7e4191e9b4803fac 100644
--- a/base/barrier_closure.cc
+++ b/base/barrier_closure.cc
@@ -28,8 +28,8 @@ BarrierInfo::BarrierInfo(int num_callbacks, const base::Closure& done_closure)
void BarrierInfo::Run() {
DCHECK(!base::AtomicRefCountIsZero(&num_callbacks_left_));
if (!base::AtomicRefCountDec(&num_callbacks_left_)) {
- done_closure_.Run();
- done_closure_.Reset();
+ base::Closure done_closure = done_closure_;
danakj 2015/04/30 17:32:55 Why no Reset still? Was it important before? There
dzhioev (left Google) 2015/04/30 20:00:54 I missed that part. Returned Reset back and added
+ done_closure.Run();
}
}
« no previous file with comments | « no previous file | base/barrier_closure_unittest.cc » ('j') | base/barrier_closure_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698