Fixed member use after destruction in BarrierClosure.

base/barrier_closure.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/barrier_closure.h"
 
 #include "base/atomic_ref_count.h"
 #include "base/bind.h"
 
 namespace {
@@ skipping 10 matching lines @@
 };
 
 BarrierInfo::BarrierInfo(int num_callbacks, const base::Closure& done_closure)
     : num_callbacks_left_(num_callbacks),
       done_closure_(done_closure) {
 }
 
 void BarrierInfo::Run() {
   DCHECK(!base::AtomicRefCountIsZero(&num_callbacks_left_));
   if (!base::AtomicRefCountDec(&num_callbacks_left_)) {
-    done_closure_.Run();
-    done_closure_.Reset();
+    base::Closure done_closure = done_closure_;

[danakj, 2015/04/30 17:32:55]

Why no Reset still? Was it important before? There appears to be no test
coverage for that Reset.

[dzhioev (left Google), 2015/04/30 20:00:54]

I missed that part. Returned Reset back and added a test case.

+    done_closure.Run();
   }
 }
 
 }  // namespace
 
 namespace base {
 
 base::Closure BarrierClosure(int num_callbacks_left,
                              const base::Closure& done_closure) {
   DCHECK_GE(num_callbacks_left, 0);
 
   if (num_callbacks_left == 0)
     done_closure.Run();
 
   return base::Bind(&BarrierInfo::Run,
                     base::Owned(
                         new BarrierInfo(num_callbacks_left, done_closure)));
 }
 
 }  // namespace base