Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1116693003: Interstitial page bug fixes (Closed)

Created:
5 years, 7 months ago by edwardjung
Modified:
5 years, 7 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SSL / malware / net error Interstitial page bug fixes + Fix padding jump across all interstitials when resizing on desktop caused by media queries being too broad. + Clock behind debug interstitial text cut off when zoomed. + Easter egg restart button fix on Windows. + Easter egg window focus / unfocus causing weird jumping. BUG=481799, 479711, 453853, 481723 Committed: https://crrev.com/e632f1ce8e4a07dbf375e74d7587a16fd092b3b3 Cr-Commit-Position: refs/heads/master@{#327905}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M chrome/browser/resources/security_warnings/interstitial_v2.css View 12 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/resources/security_warnings/interstitial_v2_mobile.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/offline.js View 2 chunks +4 lines, -3 lines 2 comments Download

Messages

Total messages: 11 (4 generated)
edwardjung
Please take a look Erik. Thanks. https://codereview.chromium.org/1116693003/diff/1/chrome/renderer/resources/offline.js File chrome/renderer/resources/offline.js (right): https://codereview.chromium.org/1116693003/diff/1/chrome/renderer/resources/offline.js#newcode700 chrome/renderer/resources/offline.js:700: }, e.button primary ...
5 years, 7 months ago (2015-04-30 10:27:00 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 7 months ago (2015-04-30 15:35:28 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116693003/1
5 years, 7 months ago (2015-05-01 11:32:37 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-01 13:32:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116693003/1
5 years, 7 months ago (2015-05-01 14:59:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-01 15:00:01 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 15:00:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e632f1ce8e4a07dbf375e74d7587a16fd092b3b3
Cr-Commit-Position: refs/heads/master@{#327905}

Powered by Google App Engine
This is Rietveld 408576698