Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: chrome/browser/resources/security_warnings/interstitial_v2.css

Issue 1116693003: Interstitial page bug fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/security_warnings/interstitial_v2.css
diff --git a/chrome/browser/resources/security_warnings/interstitial_v2.css b/chrome/browser/resources/security_warnings/interstitial_v2.css
index 7987f8033911fa93f50759ddae685c61dcc97cd3..9713d87d431e8608fd522e1be66f85145ce422d6 100644
--- a/chrome/browser/resources/security_warnings/interstitial_v2.css
+++ b/chrome/browser/resources/security_warnings/interstitial_v2.css
@@ -269,10 +269,6 @@ input[type=checkbox]:checked ~ .checkbox::before {
.error-code {
margin-top: 10px;
}
-
- .interstitial-wrapper {
- margin-top: 13%;
- }
}
@media (max-width: 420px) {
@@ -321,7 +317,7 @@ input[type=checkbox]:checked ~ .checkbox::before {
* Details message replaces the top content in its own scrollable area.
*/
-@media (max-width: 420px) and (orientation: portrait) {
+@media (max-width: 420px) and (max-height: 736px) and (orientation: portrait) {
#details-button {
border: 0;
margin: 8px 0 0;
@@ -335,7 +331,7 @@ input[type=checkbox]:checked ~ .checkbox::before {
/* Fixed nav. */
@media (min-width: 240px) and (max-width: 420px) and
- (min-height: 401px) and (orientation:portrait),
+ (min-height: 401px) and (max-height: 736px) and (orientation:portrait),
(min-width: 421px) and (max-width: 736px) and (min-height: 240px) and
(max-height: 420px) and (orientation:landscape) {
body .nav-wrapper {
@@ -345,6 +341,8 @@ input[type=checkbox]:checked ~ .checkbox::before {
left: 0;
margin: 0;
max-width: 736px;
+ padding-left: 24px;
+ padding-right: 24px;
position: fixed;
z-index: 1;
}
@@ -360,11 +358,11 @@ input[type=checkbox]:checked ~ .checkbox::before {
#details,
#main-content {
- padding-bottom: 30px;
+ padding-bottom: 40px;
}
}
-@media (max-width: 420px) and (orientation: portrait),
+@media (max-width: 420px) and (max-height: 736px) and (orientation: portrait),
(max-width: 736px) and (max-height: 420px) and (orientation: landscape) {
body {
margin: 0 auto;
@@ -382,7 +380,7 @@ input[type=checkbox]:checked ~ .checkbox::before {
.nav-wrapper {
box-sizing: border-box;
- padding: 16px 24px 8px;
+ padding-bottom: 8px;
width: 100%;
}
@@ -461,7 +459,8 @@ input[type=checkbox]:checked ~ .checkbox::before {
}
}
-@media (min-height: 405px) and (orientation:portrait) {
+@media (min-height: 405px) and (max-height: 736px) and
+ (max-width: 420px) and (orientation:portrait) {
.icon {
margin-bottom: 24px;
}
@@ -471,7 +470,8 @@ input[type=checkbox]:checked ~ .checkbox::before {
}
}
-@media (min-height: 480px) and (max-width: 420px) and (orientation: portrait),
+@media (min-height: 480px) and (max-width: 420px) and
+ (max-height: 736px) and (orientation: portrait),
(min-height: 338px) and (max-height: 420px) and (max-width: 736px) and
(orientation: landscape) {
.icon {
@@ -479,7 +479,7 @@ input[type=checkbox]:checked ~ .checkbox::before {
}
.nav-wrapper {
- padding: 16px 24px 24px;
+ padding-bottom: 24px;
}
}
@@ -490,7 +490,7 @@ input[type=checkbox]:checked ~ .checkbox::before {
}
/* Phablet sizing */
-@media (min-width: 375px) and (min-height: 641px) and
+@media (min-width: 375px) and (min-height: 641px) and (max-height: 736px) and
(max-width: 414px) and (orientation: portrait) {
button,
[dir='rtl'] button,
@@ -598,7 +598,7 @@ input[type=checkbox]:checked ~ .checkbox::before {
/* Small mobile screens. No fixed nav. */
@media (max-height: 400px) and (orientation: portrait),
(max-height: 239px) and (orientation: landscape),
- (max-width: 419px) and (max-height: 360px) {
+ (max-width: 419px) and (max-height: 399px) {
.interstitial-wrapper {
display: flex;
flex-direction: column;
@@ -627,7 +627,7 @@ input[type=checkbox]:checked ~ .checkbox::before {
}
/* Extended reporting opt-in. No fixed nav. */
-@media (max-height: 600px) and (orientation: portrait),
+@media (max-height: 736px) and (orientation: portrait),
(max-height: 360px) and (max-width: 680px) and (orientation: landscape) {
.extended-reporting-has-checkbox .interstitial-wrapper {
display: flex;

Powered by Google App Engine
This is Rietveld 408576698