Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1116683002: [media] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
Reviewers:
xhwang
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, eme-reviews_chromium.org, posciak+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, hguihot+watch_chromium.org, wjia+watch_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org, MRV
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in src/media. MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). Relanding https://codereview.chromium.org/1108773002/ BUG=391045 Committed: https://crrev.com/2fa37a05b45e8d50d3929546427106b1d4df21a9 Cr-Commit-Position: refs/heads/master@{#327653}

Patch Set 1 #

Patch Set 2 : Rebased patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -38 lines) Patch
M media/audio/audio_input_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/audio/audio_manager_base.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/base/android/media_decoder_job.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/base/android/media_drm_bridge.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/base/android/media_player_android.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/base/bind_to_current_loop.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/base/fake_text_track_stream.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/base/serial_runner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webcontentdecryptionmoduleaccess_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/test/utility/tap_proxy.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M media/cast/test/utility/udp_proxy.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M media/cast/test/utility/udp_proxy_main.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M media/cdm/default_cdm_factory.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M media/filters/default_media_permission.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/filters/fake_demuxer_stream.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/video/capture/linux/video_capture_device_chromeos.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/video/capture/mac/video_capture_device_factory_mac_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M media/video/capture/mac/video_capture_device_mac.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M media/video/capture/video_capture_device_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
anujsharma
Relanding https://codereview.chromium.org/1108773002/ CL as skyostil has added task runners to more tests in CL https://codereview.chromium.org/1105373002/ ...
5 years, 7 months ago (2015-04-29 13:45:06 UTC) #2
anujsharma
On 2015/04/29 13:45:06, anujsharma wrote: > Relanding https://codereview.chromium.org/1108773002/ CL as skyostil has added > task ...
5 years, 7 months ago (2015-04-29 13:56:50 UTC) #3
xhwang
lgtm I am not sure how to try that specific bot. You may just land ...
5 years, 7 months ago (2015-04-29 15:50:27 UTC) #4
anujsharma
On 2015/04/29 15:50:27, xhwang wrote: > lgtm > > I am not sure how to ...
5 years, 7 months ago (2015-04-29 16:29:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116683002/1
5 years, 7 months ago (2015-04-29 16:30:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/47806) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-04-29 16:35:38 UTC) #9
anujsharma
On 2015/04/29 16:35:38, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 7 months ago (2015-04-30 04:27:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116683002/20001
5 years, 7 months ago (2015-04-30 04:28:28 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-30 05:51:47 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 05:52:35 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2fa37a05b45e8d50d3929546427106b1d4df21a9
Cr-Commit-Position: refs/heads/master@{#327653}

Powered by Google App Engine
This is Rietveld 408576698