Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1105373002: Add task runners to more tests (Closed)

Created:
5 years, 7 months ago by Sami
Modified:
5 years, 7 months ago
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, feature-media-reviews_chromium.org, jam, je_julie(Not used), mcasas+watch_chromium.org, nektar+watch_chromium.org, pam+watch_chromium.org, plundblad+watch_chromium.org, posciak+watch_chromium.org, James Su, tfarina, wjia+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add task runners to more tests This patch modifies a number of tests to have a more realistic threading set-up by either: a) adding a TestBrowserThreadBundle b) constructing any existing TestBrowserThreadBundle earlier or c) adding a MessageLoop as appropriate. This makes it possible to later migrate base/ from MessageLoopProxy over to ThreadTaskRunnerHandle, which requires an active task runner on the current thread. BUG=465354, 481632 TBR=tommi@chromium.org Committed: https://crrev.com/f97a122208d5bd48d0200a83a585f005e8015353 Cr-Commit-Position: refs/heads/master@{#327463}

Patch Set 1 #

Patch Set 2 : Don't depend on content/public/test in ViewsTestBase. #

Patch Set 3 : Add missing include. #

Patch Set 4 : Dropped some unneeded changes. #

Patch Set 5 : FirstRunBubbleTest.CreateAndClose #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M chrome/browser/autocomplete/in_memory_url_index_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/supervised_user/legacy/supervised_user_sync_service_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac_unittest.mm View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_icon_painter_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/first_run_bubble_unittest.cc View 1 2 3 4 3 chunks +13 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M media/video/capture/mac/video_capture_device_factory_mac_unittest.mm View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Sami
PTAL.
5 years, 7 months ago (2015-04-28 18:41:15 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-04-28 19:01:07 UTC) #4
Sami
Thanks Jochen. TBR'ing since the media change is pretty trivial.
5 years, 7 months ago (2015-04-29 08:55:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105373002/80001
5 years, 7 months ago (2015-04-29 08:55:24 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-04-29 09:59:49 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 10:00:38 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f97a122208d5bd48d0200a83a585f005e8015353
Cr-Commit-Position: refs/heads/master@{#327463}

Powered by Google App Engine
This is Rietveld 408576698