Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1116633003: Replacing const by value return values into const by ref in chrome/browser/extensions/api/identity (Closed)

Created:
5 years, 7 months ago by payal.pandey
Modified:
5 years, 7 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replacing const by value return values into const by ref in chrome/browser/extensions/api/identity Returning a const reference to an object instead of a copy. Returning a reference to an instance that's still in scope when the function returns, then it will be faster, as no copy of the oject is being created. This CL turns const by value return values into const by ref BUG=393155 Committed: https://crrev.com/8c96177b61a9dbb176a82b1732b41dd0154336b7 Cr-Commit-Position: refs/heads/master@{#327682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/api/identity/identity_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
payal.pandey
Please have a look, Thanks.
5 years, 7 months ago (2015-04-29 11:36:32 UTC) #2
payal.pandey
Please have a look, Thanks.
5 years, 7 months ago (2015-04-29 11:36:36 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-04-30 07:16:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116633003/1
5 years, 7 months ago (2015-04-30 07:21:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 08:08:02 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 08:08:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c96177b61a9dbb176a82b1732b41dd0154336b7
Cr-Commit-Position: refs/heads/master@{#327682}

Powered by Google App Engine
This is Rietveld 408576698