chrome/browser/extensions/api/identity/identity_apitest.cc - Issue 1116633003: Replacing const by value return values into const by ref in chrome/browser/extensions/api/identity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_apitest.cc

Issue 1116633003: Replacing const by value return values into const by ref in chrome/browser/extensions/api/identity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/identity/identity_apitest.cc

diff --git a/chrome/browser/extensions/api/identity/identity_apitest.cc b/chrome/browser/extensions/api/identity/identity_apitest.cc

index 2debe5b03709497cb601818be0dc481ab33bb251..a9692b93bbadd49e2d51ad3f25d19ad82f0c9e94 100644

--- a/chrome/browser/extensions/api/identity/identity_apitest.cc

+++ b/chrome/browser/extensions/api/identity/identity_apitest.cc

@@ -724,7 +724,7 @@ class GetAuthTokenFunctionTest : public IdentityTestWithSignin {

return IdentityAPI::GetFactoryInstance()->Get(browser()->profile());

}

- const std::string GetPrimaryAccountId() {

+ const std::string& GetPrimaryAccountId() {

SigninManagerBase* signin_manager =

SigninManagerFactory::GetForProfile(browser()->profile());

return signin_manager->GetAuthenticatedAccountId();

« no previous file with comments | « no previous file | no next file » | no next file with comments »