content/renderer/renderer_webkitplatformsupport_impl.cc - Issue 11166002: Plumb render view ID from audio-related code in renderer through IPCs to AudioRendererHost in brows…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/renderer_webkitplatformsupport_impl.cc

Issue 11166002: Plumb render view ID from audio-related code in renderer through IPCs to AudioRendererHost in brows… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add plumbing for input side as well. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/pepper/pepper_platform_audio_output_impl.cc ('K') | « content/renderer/render_view_impl.cc ('k') | media/audio/audio_input_device.h » ('j') | media/audio/audio_input_device.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/renderer_webkitplatformsupport_impl.cc

diff --git a/content/renderer/renderer_webkitplatformsupport_impl.cc b/content/renderer/renderer_webkitplatformsupport_impl.cc

index c9d6e412331a317c0060b013601065b36b647778..807e5ede8ea73e62e1976cccc28f0fc1603eba84 100644

--- a/content/renderer/renderer_webkitplatformsupport_impl.cc

+++ b/content/renderer/renderer_webkitplatformsupport_impl.cc

@@ -610,7 +610,11 @@ RendererWebKitPlatformSupportImpl::createAudioDevice(

media::AudioParameters::AUDIO_PCM_LOW_LATENCY, layout,

static_cast<int>(sampleRate), 16, bufferSize);

- return new RendererWebAudioDeviceImpl(params, callback);

+ // TODO(miu): This method should be moved to RenderViewImpl. First, a WebKit

+ // change must land: https://bugs.webkit.org/show_bug.cgi?id=92718

+ // For now, a stub:

+ static const int kUnknownRenderViewId = -1;

+ return new RendererWebAudioDeviceImpl(kUnknownRenderViewId, params, callback);

}

//------------------------------------------------------------------------------