Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2084)

Unified Diff: media/audio/audio_input_device.cc

Issue 11166002: Plumb render view ID from audio-related code in renderer through IPCs to AudioRendererHost in brows… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add plumbing for input side as well. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_input_device.cc
diff --git a/media/audio/audio_input_device.cc b/media/audio/audio_input_device.cc
index e4577879900d11a47a7b13798d80e48e16bae008..19381044ef1517cd32b331d1c065af6e3b3de134 100644
--- a/media/audio/audio_input_device.cc
+++ b/media/audio/audio_input_device.cc
@@ -50,7 +50,7 @@ AudioInputDevice::AudioInputDevice(
session_id_(0),
pending_device_ready_(false),
agc_is_enabled_(false) {
- CHECK(ipc_);
+ CHECK(ipc_.get());
tommi (sloooow) - chröme 2012/10/17 18:40:06 .get() isn't necessary
miu 2012/10/17 20:10:44 Done.
}
void AudioInputDevice::Initialize(const AudioParameters& params,
@@ -209,7 +209,7 @@ void AudioInputDevice::OnDeviceReady(const std::string& device_id) {
}
void AudioInputDevice::OnIPCClosed() {
- ipc_ = NULL;
+ ipc_.reset();
}
AudioInputDevice::~AudioInputDevice() {
@@ -254,7 +254,7 @@ void AudioInputDevice::ShutDownOnIOThread() {
// NOTE: |completion| may be NULL.
// Make sure we don't call shutdown more than once.
if (stream_id_) {
- if (ipc_) {
+ if (ipc_.get()) {
tommi (sloooow) - chröme 2012/10/17 18:40:06 ditto
miu 2012/10/17 20:10:44 Done.
ipc_->CloseStream(stream_id_);
ipc_->RemoveDelegate(stream_id_);
}

Powered by Google App Engine
This is Rietveld 408576698