Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: content/browser/renderer_host/media/audio_input_renderer_host.cc

Issue 11166002: Plumb render view ID from audio-related code in renderer through IPCs to AudioRendererHost in brows… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed tommi's comments and rebased. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_input_renderer_host.cc
diff --git a/content/browser/renderer_host/media/audio_input_renderer_host.cc b/content/browser/renderer_host/media/audio_input_renderer_host.cc
index 5c7380f1c157faf4f3c3e31d7dfd8c87c68a767b..811e70cc20ec1bd03d866f7ae23c2f8ed75922a2 100644
--- a/content/browser/renderer_host/media/audio_input_renderer_host.cc
+++ b/content/browser/renderer_host/media/audio_input_renderer_host.cc
@@ -183,14 +183,24 @@ void AudioInputRendererHost::OnStartDevice(int stream_id, int session_id) {
media_stream_manager_->audio_input_device_manager()->Start(session_id, this);
}
+// TODO(miu): AudioInputRendererHost will keep track of the render_view_id
+// associated with the created audio stream in a soon-upcoming change.
void AudioInputRendererHost::OnCreateStream(
- int stream_id, const media::AudioParameters& params,
+ int render_view_id, int stream_id, const media::AudioParameters& params,
const std::string& device_id, bool automatic_gain_control) {
- VLOG(1) << "AudioInputRendererHost::OnCreateStream(stream_id="
- << stream_id << ")";
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
DCHECK(LookupById(stream_id) == NULL);
+ // TODO(miu): There is still code in the renderer which has been stubbed out,
+ // and should be implemented to plumb in the source render_view_id. In debug
+ // mode, log a WARNING until this is resolved.
+ DLOG_IF(WARNING, render_view_id <= 0)
+ << ("FIXME: AudioInputRendererHost::OnCreateStream called with unknown "
+ "render view.");
+ VLOG(1) << "AudioInputRendererHost@" << this
Chris Rogers 2012/10/17 20:43:11 shouldn't this be a DVLOG?
miu 2012/10/17 22:06:30 Done.
+ << "::OnCreateStream(render_view_id=" << render_view_id
+ << ", stream_id=" << stream_id << ")";
+
media::AudioParameters audio_params(params);
DCHECK_GT(audio_params.frames_per_buffer(), 0);

Powered by Google App Engine
This is Rietveld 408576698