Chromium Code Reviews| Index: content/browser/renderer_host/media/audio_renderer_host.cc |
| diff --git a/content/browser/renderer_host/media/audio_renderer_host.cc b/content/browser/renderer_host/media/audio_renderer_host.cc |
| index 478899c343a8dda61c25d2a1cb4593008640a073..9b91934d327621efea40cdf3a0ac8ce4d5f783f3 100644 |
| --- a/content/browser/renderer_host/media/audio_renderer_host.cc |
| +++ b/content/browser/renderer_host/media/audio_renderer_host.cc |
| @@ -194,11 +194,24 @@ bool AudioRendererHost::OnMessageReceived(const IPC::Message& message, |
| return handled; |
| } |
| +// TODO(miu): AudioRendererHost will keep track of the render_view_id associated |
| +// with the created audio stream in a soon-upcoming change. |
| void AudioRendererHost::OnCreateStream( |
| - int stream_id, const media::AudioParameters& params, int input_channels) { |
| + int render_view_id, int stream_id, const media::AudioParameters& params, |
| + int input_channels) { |
| DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); |
| DCHECK(LookupById(stream_id) == NULL); |
| + // TODO(miu): There is still code in the renderer which has been stubbed out, |
| + // and should be implemented to plumb in the source render_view_id. In debug |
| + // mode, log a WARNING until this is resolved. |
| + DLOG_IF(WARNING, render_view_id <= 0) |
| + << ("FIXME: AudioRendererHost::OnCreateStream called with unknown render " |
| + "view."); |
| + VLOG(1) << "AudioRendererHost@" << this |
|
Chris Rogers
2012/10/17 20:43:11
DVLOG
miu
2012/10/17 22:06:30
Done.
|
| + << "::OnCreateStream(render_view_id=" << render_view_id |
| + << ", stream_id=" << stream_id << ")"; |
| + |
| media::AudioParameters audio_params(params); |
| uint32 buffer_size = media::AudioBus::CalculateMemorySize(audio_params); |
| DCHECK_GT(buffer_size, 0U); |