Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1116453002: onCreateDevice -> NULL now means the caller should create its own (bitmap) device (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

onCreateDevice -> NULL now means the caller should create its own (bitmap) device BUG=skia: Committed: https://skia.googlesource.com/skia/+/61f501f8c675da8d5915e5e7fd32dfdb113f1cfb

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : update dox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -21 lines) Patch
M include/core/SkCanvas.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkDevice.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 7 chunks +29 lines, -15 lines 0 comments Download
M src/core/SkDeviceImageFilterProxy.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 2 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
reed1
ptal
5 years, 7 months ago (2015-04-28 20:03:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116453002/1
5 years, 7 months ago (2015-04-28 20:03:58 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-28 20:14:38 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116453002/20001
5 years, 7 months ago (2015-04-29 14:05:19 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-29 14:09:13 UTC) #10
robertphillips
lgtm https://codereview.chromium.org/1116453002/diff/20001/include/core/SkDevice.h File include/core/SkDevice.h (right): https://codereview.chromium.org/1116453002/diff/20001/include/core/SkDevice.h#newcode351 include/core/SkDevice.h:351: * "device back layer" -> "device back" ? ...
5 years, 7 months ago (2015-04-29 14:55:54 UTC) #11
reed1
https://codereview.chromium.org/1116453002/diff/20001/include/core/SkDevice.h File include/core/SkDevice.h (right): https://codereview.chromium.org/1116453002/diff/20001/include/core/SkDevice.h#newcode351 include/core/SkDevice.h:351: * On 2015/04/29 14:55:54, robertphillips wrote: > "device back ...
5 years, 7 months ago (2015-04-29 15:20:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116453002/40001
5 years, 7 months ago (2015-04-29 15:20:58 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 15:34:06 UTC) #16
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/61f501f8c675da8d5915e5e7fd32dfdb113f1cfb

Powered by Google App Engine
This is Rietveld 408576698