Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 111643007: Docserver: Make broken link integration test warning more visible. (Closed)

Created:
7 years ago by dhnishi (use Chromium)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Moved the broken link integration test rebasing call to action to the bottom and made the warning more visible. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244543

Patch Set 1 : #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -26 lines) Patch
M chrome/common/extensions/docs/server2/integration_test.py View 1 4 chunks +30 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dhnishi (use Chromium)
@kalman: I didn't rebase the broken link detection after r240763, so I'm rebasing it here. ...
7 years ago (2013-12-16 21:09:42 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/111643007/diff/20001/chrome/common/extensions/docs/server2/integration_test.py File chrome/common/extensions/docs/server2/integration_test.py (right): https://codereview.chromium.org/111643007/diff/20001/chrome/common/extensions/docs/server2/integration_test.py#newcode87 chrome/common/extensions/docs/server2/integration_test.py:87: print('The broken links are:') maybe leave out this ...
7 years ago (2013-12-17 20:22:37 UTC) #2
dhnishi (use Chromium)
On 2013/12/17 20:22:37, kalman wrote: > lgtm > > https://codereview.chromium.org/111643007/diff/20001/chrome/common/extensions/docs/server2/integration_test.py > File chrome/common/extensions/docs/server2/integration_test.py (right): > ...
6 years, 11 months ago (2014-01-10 20:55:26 UTC) #3
not at google - send to devlin
might as well submit it. eventually we should actually reenable the test but I don't ...
6 years, 11 months ago (2014-01-10 21:03:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/DHNishi@gmail.com/111643007/130001
6 years, 11 months ago (2014-01-13 18:52:00 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 18:54:50 UTC) #6
Message was sent while issue was closed.
Change committed as 244543

Powered by Google App Engine
This is Rietveld 408576698