Docserver: Make broken link integration test warning more visible.

chrome/common/extensions/docs/server2/integration_test.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Run build_server so that files needed by tests are copied to the local
 # third_party directory.
 import build_server
 build_server.main()
 
@@ skipping 66 matching lines @@
     #print("Checking for broken links...")
     #start_time = time.time()
     #link_error_detector = LinkErrorDetector(
     #    # TODO(kalman): Use of ChrootFileSystem here indicates a hack. Fix.
     #    ChrootFileSystem(LocalFileSystem.Create(), EXTENSIONS),
     #    lambda path: Handler(Request.ForTest(path)).Get(),
     #    'templates/public',
     #    ('extensions/index.html', 'apps/about_apps.html'))
 
     #broken_links = link_error_detector.GetBrokenLinks()
-    #if broken_links and _VERBOSE:
-    #  print('The broken links are:')
-    #  print(StringifyBrokenLinks(broken_links))
+    #if broken_links:
+    #  print('Found %d broken links.' % (
+    #    len(broken_links)))
+    #  if _VERBOSE:
+    #    print(StringifyBrokenLinks(broken_links))
 
     #broken_links_set = set(broken_links)
 
     #known_broken_links_path = os.path.join(
     #    sys.path[0], 'known_broken_links.json')
     #try:
     #  with open(known_broken_links_path, 'r') as f:
     #    # The JSON file converts tuples and sets into lists, and for this
     #    # set union/difference logic they need to be converted back.
     #    known_broken_links = set(tuple(item) for item in json.load(f))
     #except IOError:
     #  known_broken_links = set()
 
     #newly_broken_links = broken_links_set - known_broken_links
     #fixed_links = known_broken_links - broken_links_set
 
-    #if _REBASE:
-    #  print('Rebasing broken links with %s newly broken and %s fixed links.' %
-    #        (len(newly_broken_links), len(fixed_links)))
-    #  with open(known_broken_links_path, 'w') as f:
-    #    json.dump(broken_links, f,
-    #              indent=2, separators=(',', ': '), sort_keys=True)
-    #else:
-    #  if fixed_links or newly_broken_links:
-    #    print('Found %s broken links, and some have changed. '
-    #          'If this is acceptable or expected then run %s with the --rebase '
-    #          'option.' % (len(broken_links), os.path.split(__file__)[-1]))
-    #  elif broken_links:
-    #    print('Found %s broken links, but there were no changes.' %
-    #          len(broken_links))
-    #  if fixed_links:
-    #    print('%s broken links have been fixed:' % len(fixed_links))
-    #    print(StringifyBrokenLinks(fixed_links))
-    #  if newly_broken_links:
-    #    print('There are %s new broken links:' % len(newly_broken_links))
-    #    print(StringifyBrokenLinks(newly_broken_links))
-    #    self.fail('See logging for details.')
-
     #print('Took %s seconds.' % (time.time() - start_time))
 
     #print('Searching for orphaned pages...')
     #start_time = time.time()
     #orphaned_pages = link_error_detector.GetOrphanedPages()
     #if orphaned_pages:
     #  # TODO(jshumway): Test should fail when orphaned pages are detected.
-    #  print('Warning: Found %d orphaned pages:' % len(orphaned_pages))
+    #  print('Found %d orphaned pages:' % len(orphaned_pages))
     #  for page in orphaned_pages:
     #    print(page)
     #print('Took %s seconds.' % (time.time() - start_time))
 
     public_files = _GetPublicFiles()
 
     print('Rendering %s public files...' % len(public_files.keys()))
     start_time = time.time()
     try:
       for path, content in public_files.iteritems():
@@ skipping 27 matching lines @@
 
         # Samples are internationalized, test some locales.
         if path.endswith('/samples.html'):
           for lang in ['en-US', 'es', 'ar']:
             check_result(Handler(Request.ForTest(
                 path,
                 headers={'Accept-Language': '%s;q=0.8' % lang})).Get())
     finally:
       print('Took %s seconds' % (time.time() - start_time))
 
+    #if _REBASE:
+    #  print('Rebasing broken links with %s newly broken and %s fixed links.' %
+    #        (len(newly_broken_links), len(fixed_links)))
+    #  with open(known_broken_links_path, 'w') as f:
+    #    json.dump(broken_links, f,
+    #              indent=2, separators=(',', ': '), sort_keys=True)
+    #else:
+    #  if fixed_links or newly_broken_links:
+    #    print('**********************************************\n'
+    #          'CHANGE DETECTED IN BROKEN LINKS WITHOUT REBASE\n'
+    #          '**********************************************')
+    #    print('Found %s broken links, and some have changed. '
+    #          'If this is acceptable or expected then run %s with the --rebase '
+    #          'option.' % (len(broken_links), os.path.split(__file__)[-1]))
+    #  elif broken_links:
+    #    print('%s existing broken links' % len(broken_links))
+    #  if fixed_links:
+    #    print('%s broken links have been fixed:' % len(fixed_links))
+    #    print(StringifyBrokenLinks(fixed_links))
+    #  if newly_broken_links:
+    #    print('There are %s new broken links:' % len(newly_broken_links))
+    #    print(StringifyBrokenLinks(newly_broken_links))
+    #    self.fail('See logging for details.')
+
   # TODO(kalman): Move this test elsewhere, it's not an integration test.
   # Perhaps like "presubmit_tests" or something.
   def testExplicitFiles(self):
     '''Tests just the files in _EXPLICIT_TEST_FILES.
     '''
     if _EXPLICIT_TEST_FILES is None:
       return
     for filename in _EXPLICIT_TEST_FILES:
       print('Rendering %s...' % filename)
       start_time = time.time()
@@ skipping 22 matching lines @@
   parser.add_option('-v', '--verbose', action='store_true', default=False,
                     help='Show verbose output like currently broken links')
   (opts, args) = parser.parse_args()
   if not opts.all:
     _EXPLICIT_TEST_FILES = args
   _REBASE = opts.rebase
   _VERBOSE = opts.verbose
   # Kill sys.argv because we have our own flags.
   sys.argv = [sys.argv[0]]
   unittest.main()