Remove the #enable-fast-user-switcher flag.

Remove the #enable-fast-user-switcher flag.

BUG=462238
Committed: https://crrev.com/dc0f1f505a210ed01a9eddb43e0ef9100191e0c7
Cr-Commit-Position: refs/heads/master@{#330673}

[anthonyvd, 2015-05-04 21:26:20]

anthonyvd@chromium.org changed reviewers:
+ asvitkine@chromium.org, rogerta@chromium.org, sky@chromium.org

[anthonyvd, 2015-05-04 21:26:21]

Hi guys, this change removes the #enable-fast-user-switcher flag. The feature
has been replaced with fast user switching on right-click of the Avatar Button,
introduced in M42.

Could you please take a look at:

rogerta@: components/signin/*
asvitkine@: chrome/browser/ui/cocoa/*
sky@: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Thanks a lot for your time!

[Roger Tawa OOO till Jul 10th, 2015-05-11 20:19:53]

Should we be removing:

BrowserWindow::AVATAR_BUBBLE_MODE_FAST_USER_SWITCH
profiles::BUBBLE_VIEW_MODE_FAST_PROFILE_CHOOSER
ShowFastUserSwitcher()

[anthonyvd, 2015-05-15 13:54:23]

On 2015/05/11 20:19:53, Roger Tawa wrote:
> Should we be removing:
> 
> BrowserWindow::AVATAR_BUBBLE_MODE_FAST_USER_SWITCH
> profiles::BUBBLE_VIEW_MODE_FAST_PROFILE_CHOOSER
> ShowFastUserSwitcher()

We use those to display the right-click switcher still. Most of the inline fast
user switcher code was reused when making the right-click feature.

[Roger Tawa OOO till Jul 10th, 2015-05-15 14:09:30]

lgtm

OK.  I guess we still have fast user switcher, we just do it differently now.

[Alexei Svitkine (slow), 2015-05-15 14:45:32]

lgtm % nits

https://codereview.chromium.org/1116353004/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):

https://codereview.chromium.org/1116353004/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1281: for (NSView
*otherProfileView in otherProfiles) {
Nit: Space should go after the *, not before it.

https://codereview.chromium.org/1116353004/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1321: 0, yOffset,
kFixedMenuWidth, 0)];
Nit: Make a helper function for this, since you repeat it here and on line 1286
as well as below.

[sky, 2015-05-18 17:10:17]

LGTM

[anthonyvd, 2015-05-19 20:56:04]

https://codereview.chromium.org/1116353004/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):

https://codereview.chromium.org/1116353004/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1281: for (NSView
*otherProfileView in otherProfiles) {
On 2015/05/15 14:45:32, Alexei Svitkine wrote:
> Nit: Space should go after the *, not before it.

Done.

https://codereview.chromium.org/1116353004/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1321: 0, yOffset,
kFixedMenuWidth, 0)];
On 2015/05/15 14:45:32, Alexei Svitkine wrote:
> Nit: Make a helper function for this, since you repeat it here and on line
1286
> as well as below.

Done.

[anthonyvd, 2015-05-19 20:56:35]

The CQ bit was checked by anthonyvd@chromium.org to run a CQ dry run

[anthonyvd, 2015-05-19 20:56:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
rogerta@chromium.org, asvitkine@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1116353004/#ps40001
(title: "Address asvitkine@ comments.")

[commit-bot: I haz the power, 2015-05-19 20:57:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1116353004/40001

[commit-bot: I haz the power, 2015-05-19 21:02:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-19 21:02:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[anthonyvd, 2015-05-19 21:26:03]

The CQ bit was checked by anthonyvd@chromium.org to run a CQ dry run

[anthonyvd, 2015-05-19 21:26:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
rogerta@chromium.org, asvitkine@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1116353004/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2015-05-19 21:26:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1116353004/60001

[commit-bot: I haz the power, 2015-05-19 22:07:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-19 22:07:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[anthonyvd, 2015-05-19 22:30:06]

The CQ bit was checked by anthonyvd@chromium.org to run a CQ dry run

[anthonyvd, 2015-05-19 22:30:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
rogerta@chromium.org, asvitkine@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1116353004/#ps80001
(title: "Fix bad merge")

[commit-bot: I haz the power, 2015-05-19 22:32:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1116353004/80001

[commit-bot: I haz the power, 2015-05-20 00:24:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-20 00:24:51]

Dry run: This issue passed the CQ dry run.

[anthonyvd, 2015-05-20 01:49:24]

The CQ bit was checked by anthonyvd@chromium.org

[commit-bot: I haz the power, 2015-05-20 01:50:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1116353004/80001

[commit-bot: I haz the power, 2015-05-20 01:56:45]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-20 01:57:47]

Patchset 5 (id:??) landed as
https://crrev.com/dc0f1f505a210ed01a9eddb43e0ef9100191e0c7
Cr-Commit-Position: refs/heads/master@{#330673}