Remove the #enable-fast-user-switcher flag.

chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 #import <Carbon/Carbon.h>  // kVK_Return.
 
 #import "chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h"
 
 #include "base/mac/bundle_locations.h"
@@ skipping 857 matching lines @@
   return nil;
 }
 
 - (BOOL)canBecomeKeyView {
   return NO;
 }
 
 @end
 
 @interface ProfileChooserController ()
+// Builds the right-click profile switcher.
+- (void)buildFastUserSwitcherViewWithProfiles:(NSMutableArray*)otherProfiles
+                                    atYOffset:(CGFloat)yOffset
+                                  inContainer:(NSView*)container;
+
+// Builds the regular profile chooser view.
+- (void)buildProfileChooserViewWithProfileView:(NSView*)currentProfileView
+                                  tutorialView:(NSView*)tutorialView
+                                     atYOffset:(CGFloat)yOffset
+                                   inContainer:(NSView*)container
+                                   displayLock:(bool)displayLock;
+
 // Builds the profile chooser view.
 - (NSView*)buildProfileChooserView;
 
 // Builds a tutorial card with a title label using |titleMessage|, a content
 // label using |contentMessage|, a link using |linkMessage|, and a button using
 // |buttonMessage|. If |stackButton| is YES, places the button above the link.
 // Otherwise places both on the same row with the link left aligned and button
 // right aligned. On click, the link would execute |linkAction|, and the button
 // would execute |buttonAction|. It sets |tutorialMode_| to the given |mode|.
 - (NSView*)tutorialViewWithMode:(profiles::TutorialMode)mode
@@ skipping 363 matching lines @@
      [[[DummyWindowFocusButton alloc] initWithFrame:NSZeroRect] autorelease];
   [dummyFocusButton setNextKeyView:subView];
   [[self window] makeFirstResponder:dummyFocusButton];
 
   [contentView addSubview:subView];
   [contentView addSubview:dummyFocusButton];
   SetWindowSize([self window],
       NSMakeSize(NSWidth([subView frame]), NSHeight([subView frame])));
 }
 
+// Builds the fast user switcher view in |container| at |yOffset| and populates
+// it with the entries for every profile in |otherProfiles|. Returns the new
+// yOffset after adding the elements.
+- (void)buildFastUserSwitcherViewWithProfiles:(NSMutableArray*)otherProfiles
+                                    atYOffset:(CGFloat)yOffset
+                                  inContainer:(NSView*)container {
+  // Other profiles switcher. The profiles have already been sorted
+  // by their y-coordinate, so they can be added in the existing order.
+  for (NSView *otherProfileView in otherProfiles) {

[Alexei Svitkine (slow), 2015/05/15 14:45:32]

Nit: Space should go after the *, not before it.

[anthonyvd, 2015/05/19 20:56:03]

Done.

+   [otherProfileView setFrameOrigin:NSMakePoint(0, yOffset)];
+   [container addSubview:otherProfileView];
+   yOffset = NSMaxY([otherProfileView frame]);
+
+   NSBox* separator = [self horizontalSeparatorWithFrame:NSMakeRect(
+       0, yOffset, kFixedMenuWidth, 0)];
+   [container addSubview:separator];
+   yOffset = NSMaxY([separator frame]);
+  }
+
+  [container setFrameSize:NSMakeSize(kFixedMenuWidth, yOffset)];
+}
+
+- (void)buildProfileChooserViewWithProfileView:(NSView*)currentProfileView
+                                  tutorialView:(NSView*)tutorialView
+                                     atYOffset:(CGFloat)yOffset
+                                   inContainer:(NSView*)container
+                                   displayLock:(bool)displayLock {
+  // Option buttons.
+  NSRect rect = NSMakeRect(0, yOffset, kFixedMenuWidth, 0);
+  NSView* optionsView = [self createOptionsViewWithRect:rect
+                                            displayLock:displayLock];
+  [container addSubview:optionsView];
+  rect.origin.y = NSMaxY([optionsView frame]);
+
+  NSBox* separator = [self horizontalSeparatorWithFrame:rect];
+  [container addSubview:separator];
+  yOffset = NSMaxY([separator frame]);
+
+  // For supervised users, add the disclaimer text.
+  if (browser_->profile()->IsSupervised()) {
+    yOffset += kSmallVerticalSpacing;
+    NSView* disclaimerContainer = [self createSupervisedUserDisclaimerView];
+    [disclaimerContainer setFrameOrigin:NSMakePoint(0, yOffset)];
+    [container addSubview:disclaimerContainer];
+    yOffset = NSMaxY([disclaimerContainer frame]);
+    yOffset += kSmallVerticalSpacing;
+
+    NSBox* separator = [self horizontalSeparatorWithFrame:NSMakeRect(
+        0, yOffset, kFixedMenuWidth, 0)];

[Alexei Svitkine (slow), 2015/05/15 14:45:32]

Nit: Make a helper function for this, since you repeat it here and on line 1286
as well as below.

[anthonyvd, 2015/05/19 20:56:04]

Done.

+    [container addSubview:separator];
+    yOffset = NSMaxY([separator frame]);
+  }
+
+  if (viewMode_ == profiles::BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT) {
+    NSView* currentProfileAccountsView = [self createCurrentProfileAccountsView:
+        NSMakeRect(0, yOffset, kFixedMenuWidth, 0)];
+    [container addSubview:currentProfileAccountsView];
+    yOffset = NSMaxY([currentProfileAccountsView frame]);
+
+    NSBox* accountsSeparator = [self horizontalSeparatorWithFrame:
+        NSMakeRect(0, yOffset, kFixedMenuWidth, 0)];
+    [container addSubview:accountsSeparator];
+    yOffset = NSMaxY([accountsSeparator frame]);
+  }
+
+  // Active profile card.
+  if (currentProfileView) {
+    yOffset += kVerticalSpacing;
+    [currentProfileView setFrameOrigin:NSMakePoint(0, yOffset)];
+    [container addSubview:currentProfileView];
+    yOffset = NSMaxY([currentProfileView frame]) + kVerticalSpacing;
+  }
+
+  if (tutorialView) {
+    [tutorialView setFrameOrigin:NSMakePoint(0, yOffset)];
+    [container addSubview:tutorialView];
+    yOffset = NSMaxY([tutorialView frame]);
+    //TODO(mlerman): update UMA stats for the new tutorials.
+  } else {
+    tutorialMode_ = profiles::TUTORIAL_MODE_NONE;
+  }
+
+  [container setFrameSize:NSMakeSize(kFixedMenuWidth, yOffset)];
+}
+
 - (NSView*)buildProfileChooserView {
   base::scoped_nsobject<NSView> container(
       [[NSView alloc] initWithFrame:NSZeroRect]);
 
   NSView* tutorialView = nil;
   NSView* currentProfileView = nil;
   base::scoped_nsobject<NSMutableArray> otherProfiles(
       [[NSMutableArray alloc] init]);
   // Local and guest profiles cannot lock their profile.
   bool displayLock = false;
@@ skipping 27 matching lines @@
     }
   }
   if (!currentProfileView)  // Guest windows don't have an active profile.
     currentProfileView = [self createGuestProfileView];
 
   // |yOffset| is the next position at which to draw in |container|
   // coordinates. Add a pixel offset so that the bottom option buttons don't
   // overlap the bubble's rounded corners.
   CGFloat yOffset = 1;
 
-  if (!isFastProfileChooser) {
-    // Option buttons.
-    NSRect rect = NSMakeRect(0, yOffset, kFixedMenuWidth, 0);
-    NSView* optionsView = [self createOptionsViewWithRect:rect
-                                              displayLock:displayLock];
-    [container addSubview:optionsView];
-    rect.origin.y = NSMaxY([optionsView frame]);
-
-    NSBox* separator = [self horizontalSeparatorWithFrame:rect];
-    [container addSubview:separator];
-    yOffset = NSMaxY([separator frame]);
+  if (isFastProfileChooser) {
+    [self buildFastUserSwitcherViewWithProfiles:otherProfiles.get()
+                                      atYOffset:yOffset
+                                    inContainer:container.get()];
+  } else {
+    [self buildProfileChooserViewWithProfileView:currentProfileView
+                                    tutorialView:tutorialView
+                                       atYOffset:yOffset
+                                     inContainer:container.get()
+                                     displayLock:displayLock];
   }
 
-  if ((viewMode_ == profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER &&
-       switches::IsFastUserSwitching()) || isFastProfileChooser) {
-    // Other profiles switcher. The profiles have already been sorted
-    // by their y-coordinate, so they can be added in the existing order.
-    for (NSView *otherProfileView in otherProfiles.get()) {
-      [otherProfileView setFrameOrigin:NSMakePoint(0, yOffset)];
-      [container addSubview:otherProfileView];
-      yOffset = NSMaxY([otherProfileView frame]);
-
-      NSBox* separator = [self horizontalSeparatorWithFrame:NSMakeRect(
-          0, yOffset, kFixedMenuWidth, 0)];
-      [container addSubview:separator];
-      yOffset = NSMaxY([separator frame]);
-    }
-  }
-
-  // For supervised users, add the disclaimer text.
-  if (browser_->profile()->IsSupervised()) {
-    yOffset += kSmallVerticalSpacing;
-    NSView* disclaimerContainer = [self createSupervisedUserDisclaimerView];
-    [disclaimerContainer setFrameOrigin:NSMakePoint(0, yOffset)];
-    [container addSubview:disclaimerContainer];
-    yOffset = NSMaxY([disclaimerContainer frame]);
-    yOffset += kSmallVerticalSpacing;
-
-    NSBox* separator = [self horizontalSeparatorWithFrame:NSMakeRect(
-        0, yOffset, kFixedMenuWidth, 0)];
-    [container addSubview:separator];
-    yOffset = NSMaxY([separator frame]);
-  }
-
-  if (viewMode_ == profiles::BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT) {
-    NSView* currentProfileAccountsView = [self createCurrentProfileAccountsView:
-        NSMakeRect(0, yOffset, kFixedMenuWidth, 0)];
-    [container addSubview:currentProfileAccountsView];
-    yOffset = NSMaxY([currentProfileAccountsView frame]);
-
-    NSBox* accountsSeparator = [self horizontalSeparatorWithFrame:
-        NSMakeRect(0, yOffset, kFixedMenuWidth, 0)];
-    [container addSubview:accountsSeparator];
-    yOffset = NSMaxY([accountsSeparator frame]);
-  }
-
-  // Active profile card.
-  if (!isFastProfileChooser && currentProfileView) {
-    yOffset += kVerticalSpacing;
-    [currentProfileView setFrameOrigin:NSMakePoint(0, yOffset)];
-    [container addSubview:currentProfileView];
-    yOffset = NSMaxY([currentProfileView frame]) + kVerticalSpacing;
-  }
-
-  if (!isFastProfileChooser && tutorialView) {
-    [tutorialView setFrameOrigin:NSMakePoint(0, yOffset)];
-    [container addSubview:tutorialView];
-    yOffset = NSMaxY([tutorialView frame]);
-    //TODO(mlerman): update UMA stats for the new tutorials.
-  } else {
-    tutorialMode_ = profiles::TUTORIAL_MODE_NONE;
-  }
-
-  [container setFrameSize:NSMakeSize(kFixedMenuWidth, yOffset)];
   return container.autorelease();
 }
 
 - (NSView*)buildSigninConfirmationView {
   ProfileMetrics::LogProfileNewAvatarMenuSignin(
       ProfileMetrics::PROFILE_AVATAR_MENU_SIGNIN_VIEW);
 
   NSString* titleMessage = l10n_util::GetNSString(
       IDS_PROFILES_CONFIRM_SIGNIN_TUTORIAL_TITLE);
   NSString* contentMessage = l10n_util::GetNSString(
@@ skipping 923 matching lines @@
 }
 
 - (bool)shouldShowGoIncognito {
   bool incognitoAvailable =
       IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) !=
           IncognitoModePrefs::DISABLED;
   return incognitoAvailable && !browser_->profile()->IsGuestSession();
 }
 
 @end