Layout login/lock screen, shelf and app list inside the first display in Unified Desktop mode

Layout login/lock screen, shelf, app list, notifications inside the first display in Unified Desktop mode

Remove obsolete command line flag.

BUG=365662
TEST=ShelfLayoutManagerTest.ShelfLayoutInUnifiedDesktop,
ScreenUtilTest.ShelfDisplayBoundsInUnifiedDesktop

Committed: https://crrev.com/96f6a50247690d1058b1c08af2b871611c893326
Cr-Commit-Position: refs/heads/master@{#328060}

[oshima, 2015-05-01 19:39:37]

Patchset #1 (id:1) has been deleted

[oshima, 2015-05-01 19:39:42]

Patchset #1 (id:20001) has been deleted

[oshima, 2015-05-01 19:39:47]

Patchset #1 (id:40001) has been deleted

[oshima, 2015-05-01 19:39:54]

Patchset #1 (id:60001) has been deleted

[oshima, 2015-05-01 19:40:00]

Patchset #1 (id:80001) has been deleted

[oshima, 2015-05-01 20:12:42]

Patchset #1 (id:100001) has been deleted

[oshima, 2015-05-01 21:01:20]

Patchset #1 (id:120001) has been deleted

[oshima, 2015-05-01 21:02:20]

oshima@chromium.org changed reviewers:
+ mukai@chromium.org

[oshima, 2015-05-01 21:04:04]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-01 21:05:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1116313002/140001

[oshima, 2015-05-01 21:06:28]

Patchset #1 (id:140001) has been deleted

[Jun Mukai, 2015-05-01 22:14:45]

Sounds like you'll have to look into
ash/system/web_notifications/ash_popup_alingment_delegate.(h|cc) about the work
area computations.
Otherwise the notification toast appears at the bottom-right of the right
display rather than the first display, which can be far from the system
tray/message-center bubbles.

Also if the notification toasts appear in the middle of the unified screen, I a
bit worry about how the appearance animation would be.

https://codereview.chromium.org/1116313002/diff/160001/ash/display/display_co...
File ash/display/display_controller.cc (right):

https://codereview.chromium.org/1116313002/diff/160001/ash/display/display_co...
ash/display/display_controller.cc:659: 
Is this necessary?  In the extended desktop mode, display changes
(adding/removing displays) closes the system tray bubble.

[oshima, 2015-05-01 23:44:52]

thanks you for pointing out the notification. Fixed and added test. PTAL

https://codereview.chromium.org/1116313002/diff/160001/ash/display/display_co...
File ash/display/display_controller.cc (right):

https://codereview.chromium.org/1116313002/diff/160001/ash/display/display_co...
ash/display/display_controller.cc:659: 
On 2015/05/01 22:14:45, Jun Mukai wrote:
> Is this necessary?  In the extended desktop mode, display changes
> (adding/removing displays) closes the system tray bubble.

I'm showing the tray itself when necessary. It's hidden in login screen unless
explicitly shown.

[oshima, 2015-05-01 23:53:39]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-01 23:53:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1116313002/200001

[oshima, 2015-05-02 01:36:54]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-02 01:36:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1116313002/230001

[oshima, 2015-05-02 01:37:51]

https://codereview.chromium.org/1116313002/diff/230001/ash/shell_unittest.cc
File ash/shell_unittest.cc (right):

https://codereview.chromium.org/1116313002/diff/230001/ash/shell_unittest.cc#...
ash/shell_unittest.cc:378: return;
This is now necessary as the shelf's bounds uses display, not root window, and
they get out of sync on windows.

[commit-bot: I haz the power, 2015-05-02 02:08:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-02 02:09:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2015-05-02 02:19:14]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-02 02:19:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1116313002/250001

[commit-bot: I haz the power, 2015-05-02 03:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-02 03:08:48]

Dry run: Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[oshima, 2015-05-02 03:15:28]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-02 03:15:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1116313002/270001

[Jun Mukai, 2015-05-02 03:41:29]

lgtm

https://codereview.chromium.org/1116313002/diff/160001/ash/display/display_co...
File ash/display/display_controller.cc (right):

https://codereview.chromium.org/1116313002/diff/160001/ash/display/display_co...
ash/display/display_controller.cc:659: 
On 2015/05/01 23:44:52, oshima wrote:
> On 2015/05/01 22:14:45, Jun Mukai wrote:
> > Is this necessary?  In the extended desktop mode, display changes
> > (adding/removing displays) closes the system tray bubble.
> 
> I'm showing the tray itself when necessary. It's hidden in login screen unless
> explicitly shown.

Okay.  I was confused by the bubble visibility and tray widget visibility.

[commit-bot: I haz the power, 2015-05-02 04:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-02 04:11:16]

Dry run: Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[oshima, 2015-05-02 04:21:12]

Patchset #8 (id:250002) has been deleted

[oshima, 2015-05-02 04:57:44]

The CQ bit was checked by oshima@chromium.org

[oshima, 2015-05-02 04:57:44]

The patchset sent to the CQ was uploaded after l-g-t-m from mukai@chromium.org
Link to the patchset: https://codereview.chromium.org/1116313002/#ps90012
(title: " ")

[commit-bot: I haz the power, 2015-05-02 04:57:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1116313002/90012

[commit-bot: I haz the power, 2015-05-02 08:43:48]

Committed patchset #8 (id:90012)

[commit-bot: I haz the power, 2015-05-02 08:44:48]

Patchset 8 (id:??) landed as
https://crrev.com/96f6a50247690d1058b1c08af2b871611c893326
Cr-Commit-Position: refs/heads/master@{#328060}