Issue 1116163003: Merge to XFA: Make sure string constructors are efficient on literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1116163003: Merge to XFA: Make sure string constructors are efficient on literals (Closed)

Created:
5 years, 7 months ago by Tom Sepez

Modified:
5 years, 7 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Make sure string constructors are efficient on literals Besides the merge, there's one place where a wchar vs. wstring comparison was being made that no longer compiled. Original Review URL: https://codereview.chromium.org/1117263004 BUG=pdfium:151 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/997bc0e2b4fd3f43b17b9bfcec8a9cac2283cb1d

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -30 lines)			Patch
M	core/include/fxcrt/fx_string.h	View	4 chunks	+12 lines, -14 lines	0 comments	Download
M	core/src/fxcrt/fx_basic_wstring.cpp	View	2 chunks	+13 lines, -15 lines	0 comments	Download
M	xfa/src/fxfa/src/app/xfa_textlayout.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

Lei, xfa/src/fxfa/src/app/xfa_textlayout.cpp (The rest is just merge).

5 years, 7 months ago (2015-05-05 22:29:35 UTC) #1

Tom Sepez

5 years, 7 months ago (2015-05-05 22:52:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
997bc0e2b4fd3f43b17b9bfcec8a9cac2283cb1d (presubmit successful).