xfa/src/fxfa/src/app/xfa_textlayout.cpp - Issue 1116163003: Merge to XFA: Make sure string constructors are efficient on literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxfa/src/app/xfa_textlayout.cpp

Issue 1116163003: Merge to XFA: Make sure string constructors are efficient on literals (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/src/fxfa/src/app/xfa_textlayout.cpp

diff --git a/xfa/src/fxfa/src/app/xfa_textlayout.cpp b/xfa/src/fxfa/src/app/xfa_textlayout.cpp

index 82a2313692e7edff70558a4337a619551a07a335..c577042776ecb05967bbf9f0fbbf255b284c03f2 100644

--- a/xfa/src/fxfa/src/app/xfa_textlayout.cpp

+++ b/xfa/src/fxfa/src/app/xfa_textlayout.cpp

@@ -520,7 +520,7 @@ FX_BOOL CXFA_TextParser::GetEmbbedObj(IXFA_TextProvider *pTextProvider, IFDE_XML

if (wsAttr.IsEmpty()) {

return FALSE;

}

- if (wsAttr.GetAt(0) == FX_WSTRC(L"#")) {

+ if (wsAttr.GetAt(0) == L'#') {

wsAttr.Delete(0);

}

CFX_WideString ws;

« no previous file with comments | « core/src/fxcrt/fx_basic_wstring.cpp ('k') | no next file » | no next file with comments »