Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 111573002: Avoid heap allocation in SkPictureStateTree constructor (Closed)

Created:
7 years ago by Sami
Modified:
7 years ago
Reviewers:
Tom Hudson, tomhudson
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Avoid heap allocation in SkPictureStateTree constructor This makes empty state trees cheaper. ~1% improvement on rasterize_and_record_micro.key_silk_cases on Android. BUG=1772 Committed: http://code.google.com/p/skia/source/detail?r=12616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M src/core/SkPictureStateTree.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/core/SkPictureStateTree.cpp View 2 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sami
7 years ago (2013-12-10 12:43:32 UTC) #1
tomhudson
lgtm Is it just me, or does this also fix a memory leak?
7 years ago (2013-12-10 22:55:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/skyostil@chromium.org/111573002/1
7 years ago (2013-12-10 22:55:41 UTC) #3
mtklein
On 2013/12/10 22:55:24, tomhudson wrote: > lgtm > > Is it just me, or does ...
7 years ago (2013-12-10 22:59:03 UTC) #4
tomhudson
On 2013/12/10 22:59:03, mtklein wrote: > On 2013/12/10 22:55:24, tomhudson wrote: > > lgtm > ...
7 years ago (2013-12-10 23:00:42 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-10 23:06:58 UTC) #6
Message was sent while issue was closed.
Change committed as 12616

Powered by Google App Engine
This is Rietveld 408576698