Adding strict mode for bookmark_manager file for better error checking.

Adding strict mode for bookmark_manager file for better error checking.

Adding strict mode to bookmark manager's js files to detect error at load time itself.

BUG=177166
Committed: https://crrev.com/66c786a59403f02dc49df0090cece8e0e3cc3b1b
Cr-Commit-Position: refs/heads/master@{#327679}

[Deepak, 2015-04-30 03:59:29]

Please review.
Thanks

[Deepak, 2015-04-30 03:59:56]

deepak.m1@samsung.com changed reviewers:
+ bauerb@chromium.org

[Deepak, 2015-04-30 03:59:56]

PTAL

[Bernhard Bauer, 2015-04-30 07:56:05]

Cool, thanks!

LGTM assuming this doesn't trigger any errors :)

[Deepak, 2015-04-30 07:56:47]

On 2015/04/30 07:56:05, Bernhard Bauer wrote:
> Cool, thanks!
> 
> LGTM assuming this doesn't trigger any errors :)

Thanks :)

[Deepak, 2015-04-30 07:56:52]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-04-30 07:57:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115683002/1

[commit-bot: I haz the power, 2015-04-30 08:03:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-30 08:05:36]

Patchset 1 (id:??) landed as
https://crrev.com/66c786a59403f02dc49df0090cece8e0e3cc3b1b
Cr-Commit-Position: refs/heads/master@{#327679}

[Dan Beam, 2015-04-30 22:29:35]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1117143002/ by dbeam@chromium.org.

The reason for reverting is: > LGTM assuming this doesn't trigger any errors :)

It did on the closure bots. Given that this change is solely about better error
checking and it's hampering our ability to do compile-time checking with closure
compiler, I'm reverting.

deepak.m1@: you may consider adding these statement inside of a scope (e.g.
inside cr.define()) as we do a lot of file concatenation and some files might
not work with strict mode.

Here's how you check if closure compiler likes your change locally:
https://code.google.com/p/chromium/wiki/ClosureCompilation.

[Deepak, 2015-05-02 06:24:39]

On 2015/04/30 22:29:35, Dan Beam wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1117143002/ by mailto:dbeam@chromium.org.
> 
> The reason for reverting is: > LGTM assuming this doesn't trigger any errors
:)
> 
> It did on the closure bots. Given that this change is solely about better
error
> checking and it's hampering our ability to do compile-time checking with
closure
> compiler, I'm reverting.
> 
> deepak.m1@: you may consider adding these statement inside of a scope (e.g.
> inside cr.define()) as we do a lot of file concatenation and some files might
> not work with strict mode.
> 
> Here's how you check if closure compiler likes your change locally:
> https://code.google.com/p/chromium/wiki/ClosureCompilation.

ok, I have resubmitted it as https://codereview.chromium.org/1126453002/
after resolving ColsureCompilation errors.
Thanks