Pass gfx structs by const ref(gfx::Vector2D/F)

Pass gfx structs by const ref(gfx::Vector2D/F)

Pass gfx structs by const ref (gfx::Vector2d/F)
Avoid unneccessary copy of structures gfx::Vector2d/F
by passing them by const ref rather than value. Any
struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing
by value, especially when invoking function has multiple
parameters. Pass gfx structs by const ref (gfx::Vector2d/F)

BUG=159273
Committed: https://crrev.com/299999051553ce065f4277c809e7291150c26364
Cr-Commit-Position: refs/heads/master@{#327659}

[a.berwal, 2015-04-29 11:29:12]

a.berwal@samsung.com changed reviewers:
+ avi@chromium.org, danakj@chromium.org, jamesr@chromium.org

[a.berwal, 2015-04-29 11:29:13]

PTAL

[jamesr, 2015-04-29 14:12:48]

What benchmark+platform are you observing a speedup on? Can you post the numbers
on the patch description?

[danakj, 2015-04-29 17:07:28]

On 2015/04/29 14:12:48, jamesr wrote:
> What benchmark+platform are you observing a speedup on? Can you post the
numbers
> on the patch description?

Data's in the bug when we made this decision:
https://code.google.com/p/chromium/issues/detail?id=159273

[danakj, 2015-04-29 17:08:00]

LGTM

[Avi (use Gerrit), 2015-04-29 17:56:41]

lgtm

[a.berwal, 2015-04-30 03:13:34]

The CQ bit was checked by a.berwal@samsung.com

[commit-bot: I haz the power, 2015-04-30 03:13:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115653002/1

[commit-bot: I haz the power, 2015-04-30 03:38:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-30 03:38:27]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[a.berwal, 2015-04-30 04:01:40]

The CQ bit was checked by a.berwal@samsung.com

[a.berwal, 2015-04-30 04:01:40]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
avi@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1115653002/#ps20001
(title: "fixing build errors")

[commit-bot: I haz the power, 2015-04-30 04:01:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115653002/20001

[a.berwal, 2015-04-30 04:25:09]

The CQ bit was checked by a.berwal@samsung.com

[a.berwal, 2015-04-30 04:25:09]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
avi@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1115653002/#ps40001
(title: "fixing build issues")

[commit-bot: I haz the power, 2015-04-30 04:25:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115653002/40001

[commit-bot: I haz the power, 2015-04-30 05:01:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-30 05:01:15]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[a.berwal, 2015-04-30 05:54:29]

The CQ bit was checked by a.berwal@samsung.com

[a.berwal, 2015-04-30 05:54:29]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
avi@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1115653002/#ps60001
(title: "fixing some build issue")

[commit-bot: I haz the power, 2015-04-30 05:55:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115653002/60001

[commit-bot: I haz the power, 2015-04-30 06:43:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-30 06:44:10]

Patchset 4 (id:??) landed as
https://crrev.com/299999051553ce065f4277c809e7291150c26364
Cr-Commit-Position: refs/heads/master@{#327659}